Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace All Does not work #92443

Closed
yj7 opened this issue Mar 11, 2020 · 13 comments
Closed

Replace All Does not work #92443

yj7 opened this issue Mar 11, 2020 · 13 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Milestone

Comments

@yj7
Copy link

yj7 commented Mar 11, 2020

Version: 1.43.0 (user setup)
Commit: 78a4c91
Date: 2020-03-09T19:47:57.235Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363

Steps to Reproduce:

  1. Search for a string in the sidebar
  2. Open the search in the search editor
  3. Change the sidebar from search to search and replace
  4. Enter the replace string
  5. Replace all does not work

Does this issue occur when all extensions are disabled?: Yes

@vscodebot
Copy link

vscodebot bot commented Mar 11, 2020

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@MythicalFish
Copy link

MythicalFish commented Mar 11, 2020

I'm having the same issue on Mac since version 1.43.0
Clicking "Replace all" opens up the new Search Editor, but with none of the results replaced.
I'm able to edit the results but I can't save or apply.

@eladcandroid
Copy link

Same issue... Version 1.43.0, OS: Darwin x64 19.3.0

@smuuf
Copy link

smuuf commented Mar 12, 2020

Same issue, OS Win10 Insiders 19577, working with project inside WSL via Remote-WSL.

a

Replace All doesn't replace anything.

@ringcrl
Copy link

ringcrl commented Mar 13, 2020

Same issue, OS Win10 Insiders 19577, working with project inside WSL via Remote-WSL.

a

Replace All doesn't replace anything.

Version: 1.43.0
Commit: 78a4c91
Date: 2020-03-09T19:34:44.548Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.2.0

Same issue

@roblourens
Copy link
Member

This works for me. Any idea @JacksonKearl?

Are there any errors in the devtools console? (Help > Toggle Developer Tools)

@JacksonKearl
Copy link
Contributor

JacksonKearl commented Mar 15, 2020

I am able to reproduce in Stable and Insiders. Opening the search editor seems to get it into a strange state that isn't resolved until a full reload.

  1. Clean workbench. No editors or search widget contents.
  2. In vscode repo: search "test all" and put "test none" in replace field
  3. Attempt to run replace. Get confirmation message. Decline.
  4. Open in editor. Notice the "replace all" button becomes disabled.
  5. Run search widget search again, and trigger replace all. No effect.

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues labels Mar 15, 2020
@roblourens roblourens added this to the March 2020 milestone Mar 15, 2020
@roblourens
Copy link
Member

I see it. Thanks @JacksonKearl

@PerpetualWar
Copy link

PerpetualWar commented Mar 16, 2020

same problem here.... after last update, it does nothing, regardless of keyboard shortcut or UI button.

EDIT: after additional restart, it works.

@eladcandroid
Copy link

@JacksonKearl
You closed all the duplicate issues and the bug still exists...

@smuuf
Copy link

smuuf commented Mar 19, 2020

Is this maybe fixed in 1.43.1? I don't see this in list of closed issues.🤔

@eladcandroid
Copy link

@smuuf Nope...

@JacksonKearl
Copy link
Contributor

The bug is fixed in insiders. It was not in the recovery build. It will be in the next stable build.

@alexr00 alexr00 added the verified Verification succeeded label Apr 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

9 participants