New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
semanticHighlighting: Support numbers in "constant" properties #92469
Comments
(Experimental duplicate detection) |
Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue. Happy Coding! |
Hi there and thanks for the quick response! I think I might have been confused by how the different themes does the highlighting. For example: This is Dracula Soft without the And this happens when I add the Though, with Monokai Dimmed, the complete opposite happens. This is without And this is with Though this theme seems to color all properties the same way, they do not differentiate "constant" properties from normal properties. |
It looks to me that:
User defined constants breaks? Maybe there is no term for that in the |
/cc @aeschli Strange, if you use RED500 (or RED200) there is an extra token Unfortunately after couple of tests this token dissapeared. |
Ah, look there, yeah... but it seems to me that If not, then that would indeed be my feature request 😄 |
@christianalfoni How do you decide it a constant property? Because it is all uppercase? |
I don't see any bugs with the example provided. When I try is, all X in The difference to syntax highlighting is:
Here I see that we lack a rule to associate |
@aeschli Hi there! Ah, this is great. Cause:
And yeah, |
Do you still see |
Oh, is this already released? Or how would I approach testing it? |
It's in the latest insiders. |
This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines. Happy Coding! |
Hi there! Very sorry for my late reply, but I found time to check this now and it works! Great 😄 👍 Thanks for looking into this! |
With the following code:
We get the following behaviour with the
semanticHighlighting
highlighting:I would expect colors.RED_500 to be highlighted just like the two other properties.
This could maybe be considered a bug, but it could also be considered a lacking feature 😄
The text was updated successfully, but these errors were encountered: