Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web] Welcome views: links trigger unload #92633

Closed
bpasero opened this issue Mar 13, 2020 · 0 comments
Closed

[web] Welcome views: links trigger unload #92633

bpasero opened this issue Mar 13, 2020 · 0 comments
Assignees
@bpasero
Labels
candidate Issue identified as probable candidate for fixing in the next release important Issue identified as high-priority verified Verification succeeded web Issues related to running VSCode in the web
Milestone
February 2020 Rec...

Comments

@bpasero
Copy link
Member

bpasero commented Mar 13, 2020

Steps to Reproduce:

  1. run yarn web
  2. add a breakpoint into textFileEditorModelManager#dispose
  3. open debug viewlet
  4. click on link to create mock debug config

=> 馃悰 dispose of the workbench is triggered
@bpasero bpasero added important Issue identified as high-priority candidate Issue identified as probable candidate for fixing in the next release web Issues related to running VSCode in the web labels Mar 13, 2020
@bpasero bpasero added this to the February 2020 Recovery milestone Mar 13, 2020
@bpasero bpasero assigned joaomoreno, isidorn and bpasero and unassigned joaomoreno and isidorn Mar 13, 2020
bpasero added a commit that referenced this issue Mar 13, 2020
@bpasero
[web] Welcome views: links trigger unload (fix #92633)
ea1ca7f
@bpasero bpasero mentioned this issue Mar 13, 2020
Merged
bpasero added a commit that referenced this issue Mar 13, 2020
@bpasero
[web] Welcome views: links trigger unload (fix #92633) (#92635)
b723595
@bpasero bpasero closed this as completed Mar 13, 2020
bpasero added a commit that referenced this issue Mar 13, 2020
@bpasero
[web] Welcome views: links trigger unload (fix #92633) (#92635)
f7118fd
@isidorn isidorn added the verified Verification succeeded label Mar 17, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
candidate Issue identified as probable candidate for fixing in the next release important Issue identified as high-priority verified Verification succeeded web Issues related to running VSCode in the web
Projects
None yet
Milestone
February 2020 Recovery
Development

No branches or pull requests
3 participants
@joaomoreno @bpasero @isidorn