Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad use of commands argument processor #93070

Closed
bpasero opened this issue Mar 20, 2020 · 1 comment
Closed

Bad use of commands argument processor #93070

bpasero opened this issue Mar 20, 2020 · 1 comment
Assignees
@rebornix
Labels
debt Code quality issues notebook
Milestone
July 2020

Comments

@bpasero
Copy link
Member

bpasero commented Mar 20, 2020 •
edited

Looks like no command from extension was working anymore in today's insider build.

Fix in 64b65cf

As a reward, you can write an integration test that checks this works fine for the future 馃憤
@bpasero bpasero added the important Issue identified as high-priority label Mar 20, 2020
@rebornix rebornix added debt Code quality issues notebook labels Jun 25, 2020
@rebornix rebornix added this to the June 2020 milestone Jun 25, 2020
@bpasero bpasero removed the important Issue identified as high-priority label Jun 28, 2020
@rebornix rebornix modified the milestones: June 2020, July 2020 Jun 29, 2020
@rebornix
Copy link
Member

It's hard to write integration test to validate command arguments as the command execution needs to be invoked from the UI, for example, click event on a tree item, click on codelens, etc. It would be tricky to do so in integration tests so I wrote a smoke test instead.

rebornix added a commit that referenced this issue Jul 13, 2020
@rebornix
re #93070. test for command arguments.
5e96337
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
debt Code quality issues notebook
Projects
None yet
Milestone
July 2020
Development

No branches or pull requests
2 participants
@rebornix @bpasero