Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compact tree nodes do not have all accessibility attributes set #93465

Closed
Neurrone opened this issue Mar 26, 2020 · 2 comments
Closed

Compact tree nodes do not have all accessibility attributes set #93465

Neurrone opened this issue Mar 26, 2020 · 2 comments
Assignees
@joaomoreno @isidorn
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality tree-widget Tree widget issues
Milestone
On Deck

Comments

@Neurrone
Copy link

Issue Type: Bug

  1. With NVDA running, Press sctrl+shift+e and navigate to a location that has the following structure: a/b/c.txt, where a and b are otherwise empty.

Expected: these should be exposed as treeitems with information about whether it is collapsed or expanded. However, these nodes are being exposed as links instead.

VS Code version: Code - Insiders 1.44.0-insider (e62c430, 2020-03-26T05:51:24.240Z)
OS version: Windows_NT x64 10.0.18363

System Info
Item Value
CPUs Intel(R) Core(TM) i7-7500U CPU @ 2.70GHz (4 x 2904)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: enabled
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.89GB (4.80GB free)
Process Argv
Screen Reader yes
VM 0%
Extensions (13)
Extension Author (truncated) Version
vscode-eslint dba 2.1.1
gitlens eam 10.2.1
prettier-vscode esb 3.20.0
markdown-table-formatter fcr 2.0.3
vscode-mysql for 0.4.0
rest-client hum 0.23.2
rust-analyzer mat 0.2.100
Go ms- 0.13.1
vscode-typescript-tslint-plugin ms- 1.2.3
vsliveshare ms- 1.0.1847
vscode-yaml red 0.7.2
rust rus 0.7.0
vscode-webhint web 1.5.4
isidorn added a commit that referenced this issue Mar 27, 2020
@isidorn
compressed tree: add role tree item
81cb942 
#93465
@isidorn
Copy link
Contributor

isidorn commented Mar 27, 2020

@Neurrone great catch.
As a workaround I have fixed the role of those 'compact' elements as we call them. So they will now correctly have the role of treeitem.
However the correct fix would be that all tree attributes are nicely set on them. Which is aria-level, aria-expended, aria-selected, aria-posinset.

Until we get this nicely working I suggest as a workaround to disable compact elements
"explorer.compactFolders": false

Renaming this issue and also assigning to @joaomoreno

@isidorn isidorn changed the title Explorer view: folders with only 1 item are exposed as links instead of a tree item to screen readers Compact tree nodes do not have all accessibility attributes set Mar 27, 2020
@isidorn isidorn assigned joaomoreno and isidorn and unassigned isidorn Mar 27, 2020
@isidorn isidorn added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality tree-widget Tree widget issues labels Mar 27, 2020
@isidorn isidorn added this to the On Deck milestone Mar 27, 2020
@isidorn
Copy link
Contributor

isidorn commented Mar 30, 2020

Actualy duplicate of #86414

@isidorn isidorn closed this as completed Mar 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

@isidorn isidorn

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality tree-widget Tree widget issues
Projects
None yet
Milestone
On Deck
Development

No branches or pull requests
3 participants
@joaomoreno @isidorn @Neurrone