Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook document metadata: optional execution count #93618

Closed
rebornix opened this issue Mar 27, 2020 · 1 comment
Closed

Notebook document metadata: optional execution count #93618

rebornix opened this issue Mar 27, 2020 · 1 comment
Assignees
@roblourens @rebornix @jrieken
Labels
feature-request Request for new features or functionality notebook on-testplan
Milestone
March 2020

Comments

@rebornix
Copy link
Member

Issue Type: Feature Request

Currently we always the execution count placeholder [ ] when a cell is not focused/hovered, and switch to a play button when it's focused/hovered. However for GitHub issues notebook, the execution count doesn't matter at all, you can declare a macro in one cell and use it in another cell, the second cell doesn't depend on the first cell being executed.

My proposal is having a document level metadata to control if execution_count will be ever set. If no, then we don't show the [ ] placeholder.

VS Code version: Code - OSS Dev 1.44.0 (Commit unknown, Date unknown)
OS version: Darwin x64 19.2.0
@rebornix rebornix added feature-request Request for new features or functionality notebook labels Mar 27, 2020
@rebornix rebornix added this to the March 2020 milestone Mar 27, 2020
@roblourens
Copy link
Member

Could also just not show [ ] when executionOrder is undefined, then that notebook could never set it. I don't know if the placeholder brackets are that helpful

@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@rebornix rebornix

@jrieken jrieken

Labels
feature-request Request for new features or functionality notebook on-testplan
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
3 participants
@roblourens @rebornix @jrieken