Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebooks: fail to open in web #93716

Closed
bpasero opened this issue Mar 30, 2020 · 3 comments
Closed

Notebooks: fail to open in web #93716

bpasero opened this issue Mar 30, 2020 · 3 comments
Assignees
@rebornix
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority notebook verified Verification succeeded web Issues related to running VSCode in the web
Milestone
April 2020

Comments

@bpasero
Copy link
Member

bpasero commented Mar 30, 2020

This call will fail in web:

vscode/src/vs/workbench/contrib/notebook/browser/view/renderers/backLayerWebView.ts

Line 106 in 1ec4377

const loader = URI.file(path.join(environmentSerice.appRoot, '/out/vs/loader.js')).with({ scheme: WebviewResourceScheme });

I plan on removing the pieces of environment service that will not work in debt week, but for now we should fix this to enable notebooks in web.
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug web Issues related to running VSCode in the web notebook labels Mar 30, 2020
@jrieken
Copy link
Member

jrieken commented Mar 30, 2020

@rebornix We have getPathFromAmdModule and getUriFromAmdModule which might be useful here:

vscode/src/vs/base/common/amd.ts

Line 8 in 18c69d8

export function getPathFromAmdModule(requirefn: typeof require, relativePath: string): string {

@jrieken jrieken removed their assignment Mar 30, 2020
@bpasero bpasero added this to the March 2020 milestone Mar 31, 2020
@bpasero bpasero reopened this Apr 2, 2020
@bpasero bpasero added the important Issue identified as high-priority label Apr 2, 2020
@bpasero
Copy link
Member Author

bpasero commented Apr 2, 2020

Still does not work, there is more usages:

vscode/src/vs/workbench/contrib/notebook/browser/view/renderers/backLayerWebView.ts

Line 314 in 6f558be

this.localResourceRootsCache = [...this.notebookService.getNotebookProviderResourceRoots(), URI.file(this.environmentSerice.appRoot)];

//cc @jrieken

@bpasero bpasero changed the title Notebooks: are probably not fit to run in web Notebooks: fail to open in web Apr 2, 2020
@rebornix rebornix modified the milestones: March 2020, April 2020 Apr 2, 2020
@rebornix rebornix mentioned this issue Apr 2, 2020
Closed
11 tasks
@rebornix
Copy link
Member

rebornix commented Apr 3, 2020 •
edited

image

works in Web now.

@bpasero bpasero added the verified Verification succeeded label Apr 29, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority notebook verified Verification succeeded web Issues related to running VSCode in the web
Projects
None yet
Milestone
April 2020
Development

No branches or pull requests
3 participants
@rebornix @bpasero @jrieken