Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update indicator in help menu could be more descriptive #93827

Closed
bpasero opened this issue Mar 31, 2020 · 3 comments
Closed

Update indicator in help menu could be more descriptive #93827

bpasero opened this issue Mar 31, 2020 · 3 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug install-update VS Code installation and upgrade system issues linux Issues with VS Code on Linux verified Verification succeeded
Milestone
March 2020

Comments

@bpasero
Copy link
Member

bpasero commented Mar 31, 2020

image

Maybe Update: Download Now?
@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Mar 31, 2020
@joaomoreno joaomoreno added this to the March 2020 milestone Mar 31, 2020
@joaomoreno joaomoreno added the install-update VS Code installation and upgrade system issues label Mar 31, 2020
@joaomoreno
Copy link
Member

fyi @sbatten

@JacksonKearl JacksonKearl added the verified Verification succeeded label Apr 3, 2020
@JacksonKearl
Copy link
Contributor

(Assuming this is Windows because I cant figure out how I even ought to be able to get into this state on mac or linux)

I can't seem to get into this state. Even when I have "update.mode": "manual" and "update.enableWindowsBackgroundUpdates": false, when I click "check for updates" it instantly converts to the "downloading update"/"restart to update" state.

Is it a separate bug that "update.enableWindowsBackgroundUpdates": false isn't being respected?

@JacksonKearl JacksonKearl added verification-steps-needed Steps to verify are needed for verification and removed verified Verification succeeded labels Apr 3, 2020
@joaomoreno
Copy link
Member

  1. Download the Linux ZIP
  2. Extract it and change the commit field in product.json to outdated
  3. Launch it and trigger Check for Updates

@joaomoreno joaomoreno added linux Issues with VS Code on Linux and removed verification-steps-needed Steps to verify are needed for verification labels Apr 6, 2020
@JacksonKearl JacksonKearl added the verified Verification succeeded label Apr 6, 2020
@RMacfarlane RMacfarlane added verified Verification succeeded and removed verified Verification succeeded labels Apr 7, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug install-update VS Code installation and upgrade system issues linux Issues with VS Code on Linux verified Verification succeeded
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
4 participants
@joaomoreno @bpasero @RMacfarlane @JacksonKearl