Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web: terminal shutdown cannot be long running #93843

Closed
bpasero opened this issue Mar 31, 2020 · 2 comments
Closed

Web: terminal shutdown cannot be long running #93843

bpasero opened this issue Mar 31, 2020 · 2 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded web Issues related to running VSCode in the web
Milestone
April 2020

Comments

@bpasero
Copy link
Member

bpasero commented Mar 31, 2020

This code causes trouble in web:

vscode/src/vs/workbench/contrib/terminal/browser/terminalService.ts

Line 181 in a19857d

private async _onBeforeShutdown(): Promise<boolean> {

Since there is no long running shutdown, all I can do is to prevent the shutdown entirely.
@bpasero bpasero added terminal Integrated terminal issues web Issues related to running VSCode in the web labels Mar 31, 2020
bpasero added a commit that referenced this issue Mar 31, 2020
@bpasero
web - workaround terminal always preventing unload (#93843)
a86b990
@bpasero
Copy link
Member Author

bpasero commented Mar 31, 2020

I pushed a86b990 as workaround. Please check if there is any better solution possible.

@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Apr 5, 2020
@Tyriar Tyriar added this to the April 2020 milestone Apr 5, 2020
@Tyriar
Copy link
Member

Tyriar commented Apr 5, 2020

Looks good to me, thanks.

@Tyriar Tyriar closed this as completed Apr 5, 2020
@bpasero bpasero added the verified Verification succeeded label Apr 29, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded web Issues related to running VSCode in the web
Projects
None yet
Milestone
April 2020
Development

No branches or pull requests
2 participants
@bpasero @Tyriar