Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick open: no longer possible to search for files with "@" in their name #93845

Closed
bpasero opened this issue Mar 31, 2020 · 1 comment
Closed

Quick open: no longer possible to search for files with "@" in their name #93845

bpasero opened this issue Mar 31, 2020 · 1 comment
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Milestone
March 2020

Comments

@bpasero
Copy link
Member

bpasero commented Mar 31, 2020

E.g. when trying to open "build/node_modules/@typescript-eslint/parser/CHANGELOG.md" from the vscode sources folder we think we want to do a symbol search within some file.
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues labels Mar 31, 2020
@bpasero bpasero added this to the March 2020 milestone Mar 31, 2020
@bpasero bpasero self-assigned this Mar 31, 2020
@bpasero bpasero changed the title Quick open: no longer possibly to search for files with "@" in their name Quick open: no longer possible to search for files with "@" in their name Apr 1, 2020
bpasero added a commit that referenced this issue Apr 1, 2020
@bpasero
quick access - only run editor symbol search when filtering happened …
53f8664 
…already (for #93845)
@bpasero bpasero closed this as completed in b43d2e4 Apr 2, 2020
@bpasero
Copy link
Member Author

bpasero commented Apr 2, 2020 •
edited

I pushed a tactical fix which will address most issues, even though maybe not all:

  • opening quick open fresh and pasting the full path of a file that includes @ will always work if the file exists and not trigger symbol search (e.g. try with build/node_modules/@typescript-eslint/parser/CHANGELOG.md in our vscode sources). adding another @ after this path will enable symbol search on that file.
  • when you are inside quick open and you narrow down results and the active selected one contains a @ in label or description, you are now required to have at least 2 @ to start symbol search

To verify the latter, create a folder with some files that have @ in their name and verify that you can still find them when typing @ once but get into symbol search when including another @.

@JacksonKearl JacksonKearl added verified Verification succeeded and removed verified Verification succeeded labels Apr 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
2 participants
@bpasero @JacksonKearl