Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom editors: revisit constructor of CustomDocument #93867

Closed
bpasero opened this issue Mar 31, 2020 · 1 comment
Closed

Custom editors: revisit constructor of CustomDocument #93867

bpasero opened this issue Mar 31, 2020 · 1 comment
Assignees
@mjbvz
Labels
api bug Issue identified by VS Code Team member as probable bug custom-editors Custom editor API (webview based editors) verified Verification succeeded
Milestone
March 2020

Comments

@bpasero
Copy link
Member

bpasero commented Mar 31, 2020

Refs: #93767

I wonder why viewType is in the constructor, is that really needed?
@mjbvz mjbvz added this to the March 2020 milestone Mar 31, 2020
@mjbvz mjbvz added api custom-editors Custom editor API (webview based editors) labels Mar 31, 2020
@mjbvz
Copy link
Contributor

mjbvz commented Mar 31, 2020

It is needed to implement the current api

However I don't think we actually need the viewType property at all. Extensions should subclass CustomDocument instead of relying on viewType to differentiate different documents

@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Mar 31, 2020
@mjbvz mjbvz closed this as completed in d419977 Mar 31, 2020
@bpasero bpasero added the verified Verification succeeded label Apr 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
api bug Issue identified by VS Code Team member as probable bug custom-editors Custom editor API (webview based editors) verified Verification succeeded
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
2 participants
@bpasero @mjbvz