Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results sometimes not rendered #93892

Closed
isidorn opened this issue Mar 31, 2020 · 4 comments
Closed

Results sometimes not rendered #93892

isidorn opened this issue Mar 31, 2020 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 31, 2020

Refs: #93742

  1. Open a new notebook file, for example isidor.github-issues
  2. Have the following cell
label:debug repo:microsoft/vscode milestone:"March 2020" sort desc by comments		
  1. Run the query - no results get rendered 馃悰
  2. Save the notebook file, close it, reopen it and re-run the query -> result get rendered

fyi @jrieken

@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Mar 31, 2020
@rebornix rebornix added this to the March 2020 milestone Mar 31, 2020
@rebornix
Copy link
Member

Probably in the core, similar to untitled file

@isidorn
Copy link
Contributor Author

isidorn commented Apr 3, 2020

This works much better. However I still see one corner case:

  1. Run the following bad query (which produces no results)
label:debug repo:microsoft/vscode milestone:"April 2020" sort desc by comments fakeee
  1. Now run the following ok query (which produces resulsts)
label:debug repo:microsoft/vscode milestone:"April 2020" sort desc by comments

No results get rendered.
If I re-run the query under 2 all is good
Due to that re-opening the issue. Because now it is better removing from march milestone.

@isidorn isidorn reopened this Apr 3, 2020
@isidorn isidorn added the verification-found Issue verification failed label Apr 3, 2020
@isidorn isidorn removed this from the March 2020 milestone Apr 3, 2020
@jrieken jrieken closed this as completed Apr 3, 2020
@jrieken jrieken removed the verification-found Issue verification failed label Apr 3, 2020
@jrieken
Copy link
Member

jrieken commented Apr 3, 2020

@isidorn what you see is this https://github.com/microsoft/vscode/issues/94238. e.g when you append something after the sort-by-statement than it is not a sortby-statement anymore, but search text. You should have seen a change in the semantic highlights. We do this to still support search for these new keyword that we invented

@onyekaa
Copy link

onyekaa commented Apr 21, 2020

Tried this out for the first time today, can verify that certain results didn't render completely. It worked for the queries, but I had to click away to another tab then come back for the Markdown to be rendered, no reopening. Unfortunately this also cleared my query cells. These was brought back by reopening the file.

@isidorn isidorn added the verified Verification succeeded label Apr 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants