Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ITextFileService.save() should trigger more UI updating #939

Closed
bpasero opened this issue Dec 2, 2015 · 3 comments
Closed

ITextFileService.save() should trigger more UI updating #939

bpasero opened this issue Dec 2, 2015 · 3 comments
Assignees
@bpasero
Milestone
Dec 2015

Comments

@bpasero
Copy link
Member

bpasero commented Dec 2, 2015

Currently lots of UI update logic is hidden inside the save action
@bpasero bpasero self-assigned this Dec 2, 2015
@bpasero bpasero added this to the Dec 2015 milestone Dec 2, 2015
@bpasero bpasero mentioned this issue Dec 2, 2015
Closed
@jrieken
Copy link
Member

jrieken commented Dec 3, 2015

I actually don't think the text file service should update the UI but send out a good enough event such that the UI (editor service) updates accordingly.

@bpasero
Copy link
Member Author

bpasero commented Dec 3, 2015

Yeah, I was planning to use events for that 👯

@jrieken
Copy link
Member

jrieken commented Dec 3, 2015

🍻

@bpasero bpasero closed this as completed in 17680ec Dec 4, 2015
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
Dec 2015
Development

No branches or pull requests
2 participants
@bpasero @jrieken