Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick pick: Do not wrap to the other side of the list when holding up/down or page up/down #93921

Closed
Tyriar opened this issue Mar 31, 2020 · 3 comments
Closed

Quick pick: Do not wrap to the other side of the list when holding up/down or page up/down #93921

Tyriar opened this issue Mar 31, 2020 · 3 comments
Assignees
@chrmarti
Labels
bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Milestone
March 2020

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 31, 2020

#93641

Version: 1.44.0-insider (user setup)
Commit: d7d1147
Date: 2020-03-31T08:23:56.446Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18362

I think the ideal behavior here is to only wrap around the list if you press up/pgup again when you are on the first item of the list (and the same for the bottom). Without a guard like this is makes it hard to go back to the start of the list or to jump to the end of the list.

Basically, holding up and page down should take you to the top of the list as that's useful, wrapping around endlessly is not as it goes too fast to stop at the place you want.

Example of holding down page up

ffcd7f25-fb8b-4c59-bc5d-2b85f779ecaf
@bpasero bpasero assigned chrmarti and unassigned bpasero Mar 31, 2020
@bpasero bpasero added the quick-pick Quick-pick widget issues label Mar 31, 2020
@bpasero bpasero self-assigned this Mar 31, 2020
@bpasero bpasero added this to the March 2020 milestone Mar 31, 2020
@bpasero
Copy link
Member

bpasero commented Mar 31, 2020

Have to check, this maybe a list thing.

@chrmarti
Copy link
Contributor

chrmarti commented Apr 1, 2020

It's QuickInput. If we agree this is undesired, I suggest to remove it (instead of refining it in a way that is hard to discover). You can then still wrap around using up/down arrows (which is more intuitive, I think).

@bpasero
Copy link
Member

bpasero commented Apr 1, 2020 •
edited

@chrmarti I agree about removing this, I also find it not very intuitive and would expect that you simply end up on the first or last item, but never wrap. Can you make this change?

As for arrow-up/down, please leave it as is. Old quick open behaved the same.

@bpasero bpasero removed their assignment Apr 1, 2020
@chrmarti chrmarti added the bug Issue identified by VS Code Team member as probable bug label Apr 1, 2020
@Tyriar Tyriar added the verified Verification succeeded label Apr 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrmarti chrmarti

Labels
bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
3 participants
@bpasero @Tyriar @chrmarti