Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Tasks linger on recently used section, even after they are deleted #93931

Closed
joaomoreno opened this issue Mar 31, 2020 · 4 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Milestone

Comments

@joaomoreno
Copy link
Member

Testing #93746 on Linux

  1. Create a new tasks.json file
  2. Add a task A
  3. Run it
  4. Rename it to task B

馃悰 Task A still appears in the recently used task section. It even works! It even appears on reload... and WORKS! 馃槻

@joaomoreno
Copy link
Member Author

I even got it to show up like this, after deleting all tasks.json files I created:

image

@alexr00
Copy link
Member

alexr00 commented Mar 31, 2020

This was intentional so that the quick pick could be much faster and not actually go and fetch the tasks. However, I can make this better for tasks that were in a tasks.json (it won't help for purely contributed tasks though).

@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug tasks Task system issues labels Mar 31, 2020
@alexr00 alexr00 added this to the March 2020 milestone Mar 31, 2020
jeyj0 pushed a commit to jeyj0/vscode that referenced this issue Mar 31, 2020
@JacksonKearl JacksonKearl added verified Verification succeeded verification-steps-needed Steps to verify are needed for verification and removed verified Verification succeeded labels Apr 3, 2020
@JacksonKearl
Copy link
Contributor

I can make this better for tasks that were in a tasks.json

Still seeing old names from tasks.json appear - what should I be expecting?

image

@alexr00
Copy link
Member

alexr00 commented Apr 6, 2020

Since you're changing an npm task we'd need to go the the npm extension to determine if there is still a npm: watch-typecheck task. In your case you're seeing the expected behavior because the goal here is not to go the the extensions so that we can keep the picker fast.

To verify, try changing the label of a shell or process task instead. That's where I added some extra checking since those are only user defined.

@alexr00 alexr00 removed the verification-steps-needed Steps to verify are needed for verification label Apr 6, 2020
@JacksonKearl JacksonKearl added the verified Verification succeeded label Apr 6, 2020
@RMacfarlane RMacfarlane added verified Verification succeeded and removed verified Verification succeeded labels Apr 7, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants