@Tyriar where is this coming from, shouldn't it look like this now:

???

I see it's changed in the code, I reinstalled VS Code. Maybe some folders had permissions issues during an update or something 🤷‍♂

OH! I have the en-GB language pack installed...

@dbaeumer I would have thought this would invalidate the translation when the string value changes? Should we be changing the nls key if the string changes dramatically like this?

No, string values are keyed by the key we provide to the nls.localize call. This is how these translation databases work today. One idea we were discussing with them to hash the value and use it as a key but that didn't make them happy since these hash values would show up in all their tools in the user interface and they were concerned this confuses translators. So we left the key.

Bottom line: to be on the save side changing the key will fix this. But it will also be fixed when a new LP ships.

@dbaeumer does changing the en-US value trigger the string to get re-localized, if not we could be building up a significant amount of strings in other languages that no longer match the English version?

Changed the key.

@Tyriar yes, a string change in the nls.localize call will trigger a re-translation in all LP packs.