Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output mime type action feedback #93955

Closed
isidorn opened this issue Mar 31, 2020 · 4 comments
Closed

Output mime type action feedback #93955

isidorn opened this issue Mar 31, 2020 · 4 comments
Assignees
@roblourens @miguelsolorio
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues notebook polish Cleanup and polish issue
Milestone
April 2020

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 31, 2020 •
edited

Refs: #93742

Some feedback regarding the Output mime type action

  1. Use a hover message
  2. Make it accessible, so users can navigate to it via keyboard - or have it in command palette
  3. Do not trigger on right click, only trigger on left click
  4. "bulitin" description of each quick pick option not that useful. Also not readable. I suggest to not use it, or if used consider changing to "built-in"

Screenshot 2020-03-31 at 16 24 05
@rebornix rebornix added the polish Cleanup and polish issue label Mar 31, 2020
@rebornix rebornix added this to the March 2020 milestone Mar 31, 2020
@jrieken jrieken assigned roblourens and miguelsolorio and unassigned rebornix and jrieken Mar 31, 2020
@roblourens roblourens modified the milestones: March 2020, April 2020 Apr 2, 2020
@rebornix rebornix added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Apr 8, 2020
@rebornix
Copy link
Member

rebornix commented Apr 8, 2020

Now users can navigate through tabbing.

Kapture 2020-04-07 at 17 06 22

@isidorn
Copy link
Contributor Author

isidorn commented Apr 8, 2020

@rebornix nice, thanks! Should I open new issues for my concerns 1., 3. and 4?

@rebornix
Copy link
Member

rebornix commented Apr 8, 2020 •
edited

@isidorn 1 and 4 are fixed as well. I'm a bit not clear about 2, doesn't that mean "Tab"? If not feel free to create a new issue with details.

@isidorn
Copy link
Contributor Author

isidorn commented Apr 9, 2020

Yeah 2 means accessible via Tab and that works. That is why I think that one is fine and I did not mention it in my comment. I was only conerned for 1 3 and 4

@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@miguelsolorio miguelsolorio

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues notebook polish Cleanup and polish issue
Projects
None yet
Milestone
April 2020
Development

No branches or pull requests
5 participants
@roblourens @rebornix @jrieken @isidorn @miguelsolorio