-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension not synced indicator looks like a button and shows click feedback but does nothing #93989
Comments
That's a good point about it being right next to the gear button |
@Tyriar What do you mean by click feedback? Does the mouse pointer changing it for you? |
@sandy081 left mouse flashes the icon brighter briefly, right mouse makes the icon bright until released (see the white/grey color if different in the screenshot above). |
Yeah I observe it but I do not see where this change is coming from. Looks to me very subtle. Mouse gesture does not show pointer on this which is the main feedback.
Enabling it hides the icon which might not be expected behaviour for the button. I think we shall either make it a toggle button or leave it as it is now. I prefer current approach - indicating the state using icon which is not new. |
If we're not wanting to make this clickable then we should disable the pointer events on this item and make it strictly an indicator. If we want this to be clickable, we could surface a confirmation dialog asking the user if they want to sync that extension. |
Agreed. 👍 |
Removed pointer events on disabled icons in extensions view. |
This change was reverted as it is causing hovers not to be shown - #99105 Not sure how important it is to not to have click feedback instead of having an hover. Hence keeping this closed as won't fix. If there is another way to fix it please let me know I am open to reopen it. |
Fixed by b9833bb Removed the sync ignored icon from the action bar and moved into the the extension header (first row) as detail. In extension editor, made the sync ignored icon a dropdown action to toggle syncing extension. |
#93801
Version: 1.44.0-insider (user setup)
Commit: d7d1147
Date: 2020-03-31T08:23:56.446Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18362
It probably shouldn't be right next to a functioning button if it looks like one? Picked below is right click feedback.
Alternatively, clicking it could open a quick pick to sync again?
The text was updated successfully, but these errors were encountered: