Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension not synced indicator looks like a button and shows click feedback but does nothing #93989

Closed
Tyriar opened this issue Mar 31, 2020 · 9 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions polish Cleanup and polish issue settings-sync verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 31, 2020

#93801

Version: 1.44.0-insider (user setup)
Commit: d7d1147
Date: 2020-03-31T08:23:56.446Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18362


It probably shouldn't be right next to a functioning button if it looks like one? Picked below is right click feedback.

image

Alternatively, clicking it could open a quick pick to sync again?

@roblourens
Copy link
Member

That's a good point about it being right next to the gear button

@roblourens roblourens added the under-discussion Issue is under discussion for relevance, priority, approach label Apr 1, 2020
@sandy081
Copy link
Member

sandy081 commented Apr 1, 2020

@Tyriar What do you mean by click feedback? Does the mouse pointer changing it for you?

@Tyriar
Copy link
Member Author

Tyriar commented Apr 1, 2020

@sandy081 left mouse flashes the icon brighter briefly, right mouse makes the icon bright until released (see the white/grey color if different in the screenshot above).

@sandy081
Copy link
Member

sandy081 commented Apr 1, 2020

Yeah I observe it but I do not see where this change is coming from. Looks to me very subtle. Mouse gesture does not show pointer on this which is the main feedback.

clicking it could open a quick pick to sync again?

Enabling it hides the icon which might not be expected behaviour for the button. I think we shall either make it a toggle button or leave it as it is now.

I prefer current approach - indicating the state using icon which is not new.

image

@miguelsolorio
Copy link
Contributor

If we're not wanting to make this clickable then we should disable the pointer events on this item and make it strictly an indicator.

If we want this to be clickable, we could surface a confirmation dialog asking the user if they want to sync that extension.

@sandy081
Copy link
Member

sandy081 commented Apr 2, 2020

If we're not wanting to make this clickable then we should disable the pointer events on this item and make it strictly an indicator.

Agreed. 👍

@sandy081 sandy081 added this to the April 2020 milestone Apr 2, 2020
@sandy081 sandy081 added polish Cleanup and polish issue settings-sync labels Apr 2, 2020
@sandy081 sandy081 modified the milestones: April 2020, March 2020 Apr 2, 2020
@sandy081 sandy081 removed the under-discussion Issue is under discussion for relevance, priority, approach label Apr 2, 2020
@sandy081
Copy link
Member

sandy081 commented Apr 2, 2020

Removed pointer events on disabled icons in extensions view.

@sandy081 sandy081 added the extensions Issues concerning extensions label Apr 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2020
@sandy081
Copy link
Member

sandy081 commented Jun 3, 2020

This change was reverted as it is causing hovers not to be shown - #99105

Not sure how important it is to not to have click feedback instead of having an hover. Hence keeping this closed as won't fix. If there is another way to fix it please let me know I am open to reopen it.

@Tyriar Tyriar reopened this Jun 3, 2020
@microsoft microsoft unlocked this conversation Jun 3, 2020
@Tyriar Tyriar modified the milestones: March 2020, Backlog Jun 3, 2020
@sandy081
Copy link
Member

sandy081 commented Nov 4, 2020

Fixed by b9833bb

Removed the sync ignored icon from the action bar and moved into the the extension header (first row) as detail. In extension editor, made the sync ignored icon a dropdown action to toggle syncing extension.

image

@sandy081 sandy081 closed this as completed Nov 4, 2020
@sandy081 sandy081 removed this from the Backlog milestone Nov 4, 2020
@sandy081 sandy081 added this to the November 2020 milestone Nov 4, 2020
@miguelsolorio miguelsolorio added verification-needed Verification of issue is requested bug Issue identified by VS Code Team member as probable bug and removed verification-needed Verification of issue is requested labels Dec 1, 2020
@RMacfarlane RMacfarlane added the verified Verification succeeded label Dec 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions polish Cleanup and polish issue settings-sync verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants