Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider sync ignored icon #93992

Closed
Tyriar opened this issue Mar 31, 2020 · 4 comments
Closed

Reconsider sync ignored icon #93992

Tyriar opened this issue Mar 31, 2020 · 4 comments
Assignees
@roblourens @miguelsolorio
Labels
bug Issue identified by VS Code Team member as probable bug icons-product Issues for in-product icons polish Cleanup and polish issue settings-sync verified Verification succeeded
Milestone
March 2020

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 31, 2020

#93801

Version: 1.44.0-insider (user setup)
Commit: d7d1147
Date: 2020-03-31T08:23:56.446Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18362

I suggested this earlier, not sure what the reason is for going with the eye which imo is less clear as it can mean follow/watch as well. Wouldn't something like this be better as we already have a sync icon in the product?

image
@sana-ajani
Copy link
Contributor

sana-ajani commented Mar 31, 2020 •
edited

Agree, I think the eye icon indicates you can click on it to sync again the slash on the icon would go away.

@miguelsolorio
Copy link
Contributor

We did talk about using an alternate icon, I think the proposed one makes sense. How's this? This follows the same slash as the one from the ignored/hidden icon:

image

image

@miguelsolorio miguelsolorio added feature-request Request for new features or functionality icons-product Issues for in-product icons settings-sync labels Mar 31, 2020
@vscodebot vscodebot bot added this to the Backlog Candidates milestone Mar 31, 2020
@vscodebot
Copy link

vscodebot bot commented Mar 31, 2020

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

miguelsolorio pushed a commit that referenced this issue Mar 31, 2020
Update codicons: add "sync-ignored" (refs #93992) and set mappings fo…
2b5b43a 
…r new icons
@miguelsolorio
Copy link
Contributor

@roblourens @sandy081 this icon is now part of codicons as sync-ignored:

image

@sandy081 sandy081 added the polish Cleanup and polish issue label Apr 1, 2020
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug verified Verification succeeded and removed feature-request Request for new features or functionality labels Apr 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@miguelsolorio miguelsolorio

Labels
bug Issue identified by VS Code Team member as probable bug icons-product Issues for in-product icons polish Cleanup and polish issue settings-sync verified Verification succeeded
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
5 participants
@roblourens @Tyriar @sana-ajani @sandy081 @miguelsolorio