Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workspace symbols quick open do not highlight all query words #94009

Closed
octref opened this issue Mar 31, 2020 · 1 comment
Closed

Workspace symbols quick open do not highlight all query words #94009

octref opened this issue Mar 31, 2020 · 1 comment
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Milestone
March 2020

Comments

@octref
Copy link
Contributor

octref commented Mar 31, 2020

Version: 1.44.0-insider
Commit: d7d1147
Date: 2020-03-31T08:22:34.682Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 18.6.0

Ref: #93645

Steps to Reproduce:

  1. In vscode repo
  2. Type query #foo actions platform
  3. I would expect both actions and platform highlighted.

image

Does this issue occur when all extensions are disabled?: Yes/No
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues labels Apr 1, 2020
@bpasero bpasero added this to the March 2020 milestone Apr 1, 2020
@bpasero bpasero closed this as completed in c9d7e24 Apr 1, 2020
@bpasero
Copy link
Member

bpasero commented Apr 1, 2020

Quite a large change, needs verification. Now both workspace and editor symbol search will take each query input after the first to match on the container, e.g. a query like foo bar xyz more will match foo on the symbol name and individually bar, xyz and more on the container.

@connor4312 connor4312 added the verified Verification succeeded label Apr 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
3 participants
@bpasero @connor4312 @octref