Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening "refactor preview" from view picker does nothing #94010

Closed
RMacfarlane opened this issue Mar 31, 2020 · 6 comments
Closed

Opening "refactor preview" from view picker does nothing #94010

RMacfarlane opened this issue Mar 31, 2020 · 6 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Milestone
March 2020

Comments

@RMacfarlane
Copy link
Contributor

Issue Type: Bug

Testing #93636

  1. Open quickpick and type view to show view picker
  2. Under the "Panel" section, select "Refactor Preview"

No view is revealed in the panel. Same thing happens in stable, so not a regression.

VS Code version: Code - Insiders 1.44.0-insider (d7d1147, 2020-03-31T08:22:34.682Z)
OS version: Darwin x64 18.7.0
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues labels Apr 1, 2020
@bpasero bpasero added this to the March 2020 milestone Apr 1, 2020
@bpasero
Copy link
Member

bpasero commented Apr 1, 2020

@jrieken might need your help, I see that "References" for example only appear if they appear in the side bar, but "Refactor Preview" is always there. Whatever you do to make this work nicely for "References" can we do the same for "Refactor Preview"?

@bpasero
Copy link
Member

bpasero commented Apr 1, 2020

Alternatively we could allow to open this panel even if empty.

@jrieken
Copy link
Member

jrieken commented Apr 1, 2020

References view is an extension and refactor preview is built-in. Not sure what the extension integration does better...

@bpasero
Copy link
Member

bpasero commented Apr 1, 2020

@jrieken you possibly contribute a when condition which the picker evaluates here:

vscode/src/vs/workbench/contrib/quickaccess/browser/viewQuickAccess.ts

Line 97 in 8084a58

if (this.contextKeyService.contextMatchesRules(view.when)) {

@jrieken
Copy link
Member

jrieken commented Apr 1, 2020

I have that:

vscode/src/vs/workbench/contrib/bulkEdit/browser/bulkEdit.contribution.ts

Line 362 in 15bdd26

when: BulkEditPreviewContribution.ctxEnabled,

@bpasero bpasero assigned sbatten and sandy081 and unassigned jrieken, sbatten and sandy081 Apr 1, 2020
@bpasero bpasero closed this as completed in 8e1ae32 Apr 1, 2020
@bpasero
Copy link
Member

bpasero commented Apr 1, 2020

Looks like I need to check on the hideIfEmpty property also for panels.

@RMacfarlane RMacfarlane added the verified Verification succeeded label Apr 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
5 participants
@bpasero @jrieken @RMacfarlane @sbatten @sandy081