Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown cells have semantic highlighting #94038

Closed
alexdima opened this issue Mar 31, 2020 · 4 comments
Closed

Markdown cells have semantic highlighting #94038

alexdima opened this issue Mar 31, 2020 · 4 comments
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Milestone
March 2020

Comments

@alexdima
Copy link
Member

Testing #93742

  • Create a new markdown cell in a github issues notebook
  • Observe: the markdown gets semantic highlighting from queries:

image
@jrieken jrieken added this to the March 2020 milestone Apr 1, 2020
@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Apr 1, 2020
@jrieken
Copy link
Member

jrieken commented Apr 1, 2020

It's not semantic but the TM grammar

@jrieken jrieken assigned roblourens and unassigned rebornix and jrieken Apr 1, 2020
@jrieken
Copy link
Member

jrieken commented Apr 1, 2020

For some reason, the cell language is github-issues when it's being created. Something with those commands is wrong...

@roblourens
Copy link
Member

Hadn't noticed this. @rebornix I think the markdown cell text model is just picking up the language from the file extension, what's the right way to force it to be markdown? setMode? How do I get the language identifier?

@rebornix
Copy link
Member

rebornix commented Apr 1, 2020

For markdown cell there is no language metadata so it falls back to file extension by mistake ... pushed a fix.

@RMacfarlane RMacfarlane added the verified Verification succeeded label Apr 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
5 participants
@roblourens @rebornix @jrieken @RMacfarlane @alexdima