Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent: Preferences sync or Settings sync? #94062

Closed
chrisdias opened this issue Mar 31, 2020 · 0 comments
Closed

Inconsistent: Preferences sync or Settings sync? #94062

chrisdias opened this issue Mar 31, 2020 · 0 comments
Assignees
@RMacfarlane
Labels
bug Issue identified by VS Code Team member as probable bug settings-sync verified Verification succeeded
Milestone
March 2020

Comments

@chrisdias
Copy link
Member

chrisdias commented Mar 31, 2020 •
edited

testing #93811

Version: 1.44.0-insider
Commit: d7d1147d6b764a48b789000c03088ee9afabcd8a
Date: 2020-03-31T08:22:34.682Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 17.7.0

I'm not seeing "Turn on Sync" in the gear menu for some reason, but when I restart VS Code Insiders I get prompted for this (I'm logged in 2x obviously):

image

It says "Preferences Sync: Choose Account" but in the quick pick it says "Choose an account you would like to use for settings sync".

We're saying both Preferences and Settings, we should pick one and be consistent, unless in a specific context (e.g. in settings).
@sandy081 sandy081 assigned RMacfarlane and unassigned sandy081 Apr 1, 2020
@RMacfarlane RMacfarlane added bug Issue identified by VS Code Team member as probable bug settings-sync labels Apr 1, 2020
@RMacfarlane RMacfarlane added this to the March 2020 milestone Apr 1, 2020
@Tyriar Tyriar added the verified Verification succeeded label Apr 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RMacfarlane RMacfarlane

Labels
bug Issue identified by VS Code Team member as probable bug settings-sync verified Verification succeeded
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
4 participants
@chrisdias @Tyriar @RMacfarlane @sandy081