Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better read unchanged lines in F7 diff view #94087

Closed
JacksonKearl opened this issue Mar 31, 2020 · 4 comments
Closed

Better read unchanged lines in F7 diff view #94087

JacksonKearl opened this issue Mar 31, 2020 · 4 comments
Assignees
@isidorn
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues diff-editor Diff editor mode issues
Milestone
April 2020

Comments

@JacksonKearl
Copy link
Contributor

JacksonKearl commented Mar 31, 2020 •
edited

ref #93301

With this diff, the reader will read

private label: string original line 14 modified line 14

it might be good to just notate that its unchanged?

private label: string unchanged line 14

@@ -14,10 +14,10 @@ export class FeatureRequestQueryer {
                private label: string,
                private reactionsRequired: number,
                private commentsOverride: number,
-               // private initComment: string,
-               // private warnComment: string,
+               private initComment: string,
+               private warnComment: string,
                private acceptComment: string,
-               // private rejectComment: string
+               private rejectComment: string
        ) { }

VSCode's rendering of the above diff:
image

macOS mojave voiceover
@alexdima alexdima assigned isidorn and unassigned alexdima Apr 1, 2020
@isidorn
Copy link
Contributor

isidorn commented Apr 1, 2020

@JacksonKearl makes sense. Agree with you. Assigning to April to look into polishing this then.

@isidorn isidorn added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues diff-editor Diff editor mode issues labels Apr 1, 2020
@isidorn isidorn added this to the April 2020 milestone Apr 1, 2020
@jvesouza
Copy link

jvesouza commented Apr 1, 2020

I will probably write a lot of nonsense, but since the lines are shown preceded by a - / +, wouldn't it be enough to just announce the line number?
I may be contaminated by the fact that I almost always used git in text mode.

@isidorn
Copy link
Contributor

isidorn commented Apr 1, 2020 •
edited

@jvesouza I believe that just announcing the line number would be far too concise and not enough for most users.

@MarcoZehe
Copy link
Contributor

Agreed, many synthesizers may read the + sign, but not the - sign because it is also used as a dash. Granted, at some point all punctuation might be spoken by some users, but that is not always unambiguous. So speaking whether this is a deleted line or so is very important.

isidorn added a commit that referenced this issue Apr 29, 2020
@isidorn
fuxes #94087
791156d
@isidorn isidorn closed this as completed Apr 29, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues diff-editor Diff editor mode issues
Projects
None yet
Milestone
April 2020
Development

No branches or pull requests
5 participants
@MarcoZehe @isidorn @jvesouza @alexdima @JacksonKearl