Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No message when having no results #94145

Closed
jrieken opened this issue Apr 1, 2020 · 3 comments
Closed

No message when having no results #94145

jrieken opened this issue Apr 1, 2020 · 3 comments
Assignees
@bpasero
Labels
quick-pick Quick-pick widget issues regression Something that used to work is now broken verification-needed Verification of issue is requested verified Verification succeeded
Milestone
March 2020

Comments

@jrieken
Copy link
Member

jrieken commented Apr 1, 2020

re #93645

  • select text that's unlikely to occur as symbol name, like =>
  • press cmd+t for workspace symbols
  • 馃悰 there is no visible progress but also no message that nothing has been found

image
@bpasero
Copy link
Member

bpasero commented Apr 1, 2020

Similar to #94007

I decided to drop the "no results default pick" from pickers to align with what all pickers do when there are no results, e.g. for language mode:

image

I am not sure it is good to have inconsistency around this where some pickers always show a result and others do not.

Personally I feel the indication that no results match not very useful, but we can have a UX discussion if it should come back.

@chrmarti thoughts?

@bpasero bpasero added quick-pick Quick-pick widget issues under-discussion Issue is under discussion for relevance, priority, approach labels Apr 1, 2020
@bpasero bpasero added this to the March 2020 milestone Apr 1, 2020
@jrieken
Copy link
Member Author

jrieken commented Apr 1, 2020

To me there is a difference between pickers that are populated immediately (or very, very quickly) like commands or outline and those that can take a while to populate, like workspace symbol search

@bpasero bpasero added verification-needed Verification of issue is requested regression Something that used to work is now broken and removed under-discussion Issue is under discussion for relevance, priority, approach labels Apr 2, 2020
@bpasero
Copy link
Member

bpasero commented Apr 2, 2020 •
edited

I will bring this back for the following quick pickers:

  • files (Cmd+P)
  • symbols (#)
  • commands (>)
  • editors (edt)
  • debug (debug)
  • views (view)

Verification:

  • go through these pickers and produce no results
  • verify you see a meaningful message appearing (pressing enter will not close the picker though)
  • verify you only see this message when you searched for something, not initially

@bpasero bpasero closed this as completed in 6f558be Apr 2, 2020
@roblourens roblourens added verified Verification succeeded and removed verified Verification succeeded labels Apr 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2020
@RMacfarlane RMacfarlane added the verified Verification succeeded label Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
quick-pick Quick-pick widget issues regression Something that used to work is now broken verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
4 participants
@roblourens @bpasero @jrieken @RMacfarlane