Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contribution point for timeline provider #94151

Closed
sandy081 opened this issue Apr 1, 2020 · 7 comments · Fixed by #148052
Closed

Contribution point for timeline provider #94151

sandy081 opened this issue Apr 1, 2020 · 7 comments · Fixed by #148052
Assignees
@lramos15 @JacksonKearl
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders timeline Timeline view issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
May 2022

Comments

@sandy081
Copy link
Member

sandy081 commented Apr 1, 2020

Testing #93820

Why is not there a package.json contribution point for timeline provider? Following are the advantages

  • I am not sure how I have to activate my extension if I only contribute timeline provider. Having a timeline contribution point can allow me to activate my extension when user starts using the timeline my extension contributes

  • Also helps in displaying the feature contributions in extension editor view
@eamodio eamodio added feature-request Request for new features or functionality timeline Timeline view issues labels Apr 7, 2020
@eamodio eamodio added this to the Backlog milestone Apr 7, 2020
@eamodio eamodio mentioned this issue Apr 7, 2020
Closed
@eamodio
Copy link
Contributor

eamodio commented Apr 7, 2020

@sandy081: @jrieken and I talked about supporting this originally but felt that it was something that could be added later.

@jrieken
Copy link
Member

jrieken commented Apr 7, 2020

Hm, not sure... Somehow timeline feels like master-detail, e.g you open an editor and the timeline shows its contents. With that usage-pattern it feels wrong to have an activation event. Then there is the 'Open timeline' command which is different... You could that command as activation event and all is good

@sandy081
Copy link
Member Author

sandy081 commented Apr 7, 2020

On what event shall an extension contributing a timeline should be activated?

@jrieken
Copy link
Member

jrieken commented Apr 7, 2020

For instance these onCommand:openTimeline and onFilesystem:foo

@eamodio
Copy link
Contributor

eamodio commented Oct 7, 2020

@jrieken should we support an onView:timeline activation? Rather than a really specific point just for the timeline?

@jrieken
Copy link
Member

jrieken commented Oct 8, 2020

Yeah, that would make sense

@lramos15 lramos15 assigned JacksonKearl and unassigned eamodio Oct 8, 2021
@JacksonKearl JacksonKearl modified the milestones: Backlog, On Deck Oct 8, 2021
@JacksonKearl JacksonKearl modified the milestones: On Deck, April 2022 Apr 8, 2022
lramos15 added a commit that referenced this issue Apr 25, 2022
@lramos15
Fix #94151
9816a53
@lramos15 lramos15 mentioned this issue Apr 25, 2022
Merged
@lramos15 lramos15 modified the milestones: April 2022, May 2022 Apr 26, 2022
lramos15 added a commit that referenced this issue May 6, 2022
@lramos15
Fix #94151 (#148052)
df5abb3
@kieferrm kieferrm mentioned this issue May 7, 2022
Closed
99 tasks
@lramos15 lramos15 added the verification-needed Verification of issue is requested label May 27, 2022
@lramos15
Copy link
Member

To verify ensure that your extension that contributes a timeline can activate properly when the timeline is revealed via the onView:timeline activation

@sandy081 sandy081 added the verified Verification succeeded label Jun 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lramos15 lramos15

@JacksonKearl JacksonKearl

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders timeline Timeline view issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
May 2022
Development

Successfully merging a pull request may close this issue.

Add onView:timeline activation. microsoft/vscode
6 participants
@eamodio @jrieken @lramos15 @JacksonKearl @sandy081 and others