New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminal: moving panel right leaves prompt in weird place #94501
Comments
I can't repro on macOS with bash or zsh. What state was the terminal in before you moved it? |
Hm, cannot reproduce with a fresh user data dir. How can I debug this? |
What I suspect is happening is that zsh is doing this as a reaction to the line size being reduced. This could be confirmed by enabling escape sequence logging https://github.com/microsoft/vscode/wiki/Terminal-Issues#enabling-escape-sequence-logging, that should log out how zsh reacts after the terminal resize happens. You could also check what happens when reducing the window width while the panel is on the bottom. |
@Tyriar yeah that seems to trigger it as well, just having smaller width for panel: |
Output:
|
Hmm I guess not then, that does the following: [0m: clear char styles If you inspect the element does the terminal container fill the view? Does cmd+a select everthing? |
😕 Ok so that tells us that xterm.js isn't resizing correctly. I just tried to repro again with all renderers but couldn't still. Does it change depending on the renderer you're using? I did just made changes in this area in 5b0460a. Could you try change these lines: vscode/src/vs/workbench/contrib/terminal/browser/terminalConfigHelper.ts Lines 190 to 191 in 831fe1f
To: charHeight: xtermCore._charSizeService!.height!,
charWidth: xtermCore._charSizeService!.width! And see if that fixes the problem? |
@Tyriar yes, that fixes it. Btw I am running with zoom level 1 always. |
@bpasero thanks, I think that's the piece I was missing 😃 I can kind of reproduce, it's only down a little bit but that might be because of the font family or monitor size. |
@bpasero hmm, maybe not... Could you debug and take a screenshot of the values of: |
Can you try with |
This was running out of sources:
The text was updated successfully, but these errors were encountered: