Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splitting a custom editor multiple times results in too many editor instances #95487

Closed
mjbvz opened this issue Apr 17, 2020 · 0 comments
Closed

Splitting a custom editor multiple times results in too many editor instances #95487

mjbvz opened this issue Apr 17, 2020 · 0 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug custom-editors Custom editor API (webview based editors) verified Verification succeeded webview Webview issues
Milestone
April 2020

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Apr 17, 2020

Issue Type: Bug

repro

  1. On mac.
  2. Open the built-in image preview
  3. Hold down cmd then press \ to split
  4. Continue holding down cmd but now press \ again

Expected
There should be 3 editors open.

Bug
There are now 4 editors open.

VS Code version: Code - Insiders 1.45.0-insider (6e9a34c, 2020-04-16T05:41:45.257Z)
OS version: Darwin x64 19.4.0

System Info
Item Value
CPUs Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled
Load (avg) 3, 3, 3
Memory (System) 32.00GB (1.17GB free)
Process Argv -psn_0_12385231
Screen Reader no
VM 17%
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug webview Webview issues custom-editors Custom editor API (webview based editors) labels Apr 17, 2020
@mjbvz mjbvz added this to the April 2020 milestone Apr 17, 2020
@mjbvz mjbvz self-assigned this Apr 17, 2020
@mjbvz mjbvz closed this as completed in ad2df06 Apr 17, 2020
@roblourens roblourens added the verified Verification succeeded label Apr 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug custom-editors Custom editor API (webview based editors) verified Verification succeeded webview Webview issues
Projects
None yet
Milestone
April 2020
Development

No branches or pull requests
2 participants
@roblourens @mjbvz