Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using createMatches with offset is bogous #96256

Closed
jrieken opened this issue Apr 27, 2020 · 1 comment
Closed

Using createMatches with offset is bogous #96256

jrieken opened this issue Apr 27, 2020 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Apr 27, 2020

Stumbled over the new offset parameter of createMatches:

export function createMatches(score: undefined | FuzzyScore, offset = 0): IMatch[] {

This tells me that something hasn't been understood because FuzzyScore itself already has the notion of an offset. The idea is that no substrings are created but fuzzyScore (and its cousins) should be called with a wordPos which is the offset at which matching should start inside a word. That offset is that captured inside the score and used when creating matches. The new offset doesn't fit into this.

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues labels Apr 27, 2020
@bpasero bpasero added this to the April 2020 milestone Apr 27, 2020
@bpasero
Copy link
Member

bpasero commented Apr 27, 2020

Verification: use quick outline and search. The highlights should be proper and results too.

leilapearson pushed a commit to relmify/vscode that referenced this issue Apr 27, 2020
@jrieken jrieken added the verified Verification succeeded label Apr 28, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants