Using createMatches
with offset is bogous
#96256
Labels
bug
Issue identified by VS Code Team member as probable bug
quick-pick
Quick-pick widget issues
verified
Verification succeeded
Milestone
Stumbled over the new
offset
parameter ofcreateMatches
:vscode/src/vs/base/common/filters.ts
Line 395 in 4711909
This tells me that something hasn't been understood because
FuzzyScore
itself already has the notion of an offset. The idea is that no substrings are created butfuzzyScore
(and its cousins) should be called with awordPos
which is the offset at which matching should start inside a word. That offset is that captured inside the score and used when creating matches. The new offset doesn't fit into this.The text was updated successfully, but these errors were encountered: