Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all rulers are being displayed when using zoom level less than 0 #9634

Closed
johncruise opened this issue Jul 22, 2016 · 11 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug electron Issues and items related to Electron upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded zoom VS Code window zoom issues
Milestone

Comments

@johncruise
Copy link

johncruise commented Jul 22, 2016

  • VSCode Version: 1.4.0-insider (2016-07-22T05:07:03.113Z)
  • OS Version: Windows 7

Steps to Reproduce:

  1. In settings, setup editor.rulers to [71, 99]
  2. Setup window.zoomLevel to -1
  3. Setup editor.fontSize to 13
  4. Reload Window
  5. Open any file
  6. Open split editor window (ctrl+)

After above, most of the time the 2nd ruler at the left window does not show up. This only started manifesting on newer version (no problem with older version)

@kieferrm
Copy link
Member

It seems that there are general issues with multiple rulers when the zoom level is -1 depending on how wide an editor is.

3vqqhsyx0m

@johncruise
Copy link
Author

Thank you for confirming. The show-and-tell screenshot is very informative RE: how to get around this. Unfortunately, in my environment the left pane doesn't show the other ruler no matter how I resize the width. What I end up doing (to get a side-by-side code experience) is open the 3rd/last editor pane and minimize the width of the left most. Ugly solution but it works.

Please keep the bug open until there's a permanent fix. Thanks for the support.

@alexdima
Copy link
Member

I think this is how Chromium deals with a 1px vertical line when it is zoomed below 100%. My recommendation is to not use window.zoomLevel.

@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Aug 16, 2016
@alexdima alexdima added this to the Backlog milestone Aug 16, 2016
@johncruise
Copy link
Author

johncruise commented Aug 17, 2016

Not using window.zoomLevel as a solution is not enticing in my case. The reason why I use it is because all the window component of vscode are a tad big for my taste (icons, folder or solution view, etc) and although I like to see them all the time so I can navigate through my files, they are just taking too much space.

I will only go back to 100% zoom level if there's a way for me to customize font size of the other elements of the window that is not tied up to the editor window's font.

Nevertheless, thanks for the follow up.

@alexdima
Copy link
Member

👍 I would also like a way to customize the font size of other elements of the window. Please create an issue for that so I can upvote it :). The zoom level is a cheap trick that causes multiple problems, such as this one, or breaking antialising, etc.

@johncruise
Copy link
Author

I'll create one. Thanks for the recommendation.

@eldarshamukhamedov
Copy link

Here is @johncruise's followup ticket: #10605. How do you guys feel about allowing the ruler width to be styled via themes? Could be a quick fix for the relatively small group of users who are affected by this.

@alexdima
Copy link
Member

alexdima commented Jun 14, 2017

The same happens when using for example the Zoom Level on Windows to something like 125%. Some rulers are 1px wide and some are 2px wide depending on how the rulers align with the screen pixels:

image

When Windows is set to 125% and window.zoomLevel: -2:

image

Thanks to the help from @fj128 in discussions in #28542 , we have a plan on how to workaround this.

@alexdima
Copy link
Member

With the technique discussed in #28542:

When Windows is set to 125% and window.zoomLevel: 0:
image

When Windows is set to 125% and window.zoomLevel: -2:
image

@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Jun 14, 2017
@alexdima alexdima modified the milestones: July 2017, Backlog, June 2017 Jun 14, 2017
@michelkaporin michelkaporin added the verified Verification succeeded label Jun 29, 2017
@KernelDeimos
Copy link

Why is this closed? I have no idea what to do about this. Is it possible to configure the thickness of the ruler?

@fj128
Copy link

fj128 commented Jul 2, 2017 via email

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug electron Issues and items related to Electron upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded zoom VS Code window zoom issues
Projects
None yet
Development

No branches or pull requests

7 participants