Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputBox: prompt should support codicons #96430

Closed
joaomoreno opened this issue Apr 28, 2020 · 3 comments
Closed

InputBox: prompt should support codicons #96430

joaomoreno opened this issue Apr 28, 2020 · 3 comments
Assignees
@chrmarti
Labels
feature-request Request for new features or functionality quick-pick Quick-pick widget issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
November 2020

Comments

@joaomoreno
Copy link
Member

This should get me a codicon-add icon in the input box prompt label:

			const input = await vscode.window.showInputBox({
				placeHolder: 'Name',
				prompt: '$(add) Create'
			});
@chrmarti
Copy link
Contributor

@joaomoreno I guess this must be trivial, do you have a code pointer on how to do it?

@chrmarti chrmarti added feature-request Request for new features or functionality quick-pick Quick-pick widget issues labels Apr 29, 2020
@chrmarti chrmarti added this to the Backlog milestone Apr 29, 2020
@joaomoreno
Copy link
Member Author

Yeah, here's me adopting it in the Button class: b005f53

@chrmarti chrmarti modified the milestones: Backlog, May 2020 Apr 30, 2020
@chrmarti chrmarti modified the milestones: May 2020, June 2020 Jun 2, 2020
@chrmarti chrmarti modified the milestones: June 2020, July 2020 Jul 2, 2020
@devanshj devanshj mentioned this issue Jul 19, 2020
Closed
@joaomoreno
Copy link
Member Author

Pushing out to August.

@joaomoreno joaomoreno modified the milestones: July 2020, August 2020 Aug 5, 2020
@chrmarti chrmarti modified the milestones: August 2020, September 2020 Sep 3, 2020
@chrmarti chrmarti modified the milestones: September 2020, October 2020 Oct 1, 2020
@chrmarti chrmarti modified the milestones: October 2020, November 2020 Oct 28, 2020
chrmarti pushed a commit that referenced this issue Nov 18, 2020
@devanshj @chrmarti
Codicons in prompt (#96430)
a34cad5
chrmarti added a commit that referenced this issue Nov 18, 2020
@chrmarti
Codicons in prompt (#96430)
f9c3f0d
meganrogge pushed a commit that referenced this issue Nov 18, 2020
@devanshj @meganrogge
Codicons in prompt (#96430)
af87f0f
meganrogge pushed a commit that referenced this issue Nov 18, 2020
@chrmarti @meganrogge
Codicons in prompt (#96430)
c0c2311
@chrmarti chrmarti added the verification-needed Verification of issue is requested label Dec 1, 2020
@joaomoreno joaomoreno added the verified Verification succeeded label Dec 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrmarti chrmarti

Labels
feature-request Request for new features or functionality quick-pick Quick-pick widget issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
November 2020
Development

Successfully merging a pull request may close this issue.

feat(quickinput): support codicons in prompt devanshj/vscode
2 participants
@joaomoreno @chrmarti