Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu items are not getting disposed #96970

Closed
sandy081 opened this issue May 5, 2020 · 0 comments
Closed

Menu items are not getting disposed #96970

sandy081 opened this issue May 5, 2020 · 0 comments
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug menus Menu items and widget issues verified Verification succeeded
Milestone
May 2020

Comments

@sandy081
Copy link
Member

sandy081 commented May 5, 2020

Running out of sources

  • Move timeline view to Problems panel
    馃悰 Timeline title actions are duplicated

After investigating it seems like menu items are not getting disposed and this commit caused it
@sandy081 sandy081 added the bug Issue identified by VS Code Team member as probable bug label May 5, 2020
@jrieken jrieken added this to the May 2020 milestone May 5, 2020
@jrieken jrieken closed this as completed in 719ac74 May 5, 2020
@jrieken jrieken added the menus Menu items and widget issues label May 5, 2020
@sandy081 sandy081 added the verified Verification succeeded label Jun 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug menus Menu items and widget issues verified Verification succeeded
Projects
None yet
Milestone
May 2020
Development

No branches or pull requests
2 participants
@jrieken @sandy081