Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debugger: error text from configurationDone is not shown to the user #97110

Closed
gregg-miskelly opened this issue May 7, 2020 · 4 comments
Closed

Debugger: error text from configurationDone is not shown to the user #97110

gregg-miskelly opened this issue May 7, 2020 · 4 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone
May 2020

Comments

@gregg-miskelly
Copy link
Member

Issue Type: Bug

Issue

If a debug adapter fails configurationDone, then debugging stops. But VS Code will no longer show the user the error message that the debug adapter sent.

This issue was previously reported and fixed (see #87745) but it has regressed in the most recent version of VS Code (insiders and standard).

Insiders version that I checked:
Version: 1.45.0-insider (system setup)
Commit: d69a79b
Date: 2020-05-06T09:26:27.927Z
Electron: 7.2.4
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363
@gregg-miskelly
Copy link
Member Author

CC @isidorn

@isidorn isidorn self-assigned this May 7, 2020
@isidorn isidorn closed this as completed in 4c1fb1d May 8, 2020
@isidorn
Copy link
Contributor

isidorn commented May 8, 2020 •
edited

@gregg-miskelly I have no clue how I removed the .error call in the past couple of releases, but reintroduced it now so we should be good.
Try it out with VS Code insiders from Monday and let me know how it goes. Thanks for reporting good issues!

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels May 8, 2020
@isidorn isidorn added this to the May 2020 milestone May 8, 2020
@gregg-miskelly
Copy link
Member Author

@isidorn Thanks for the quick fix. Works great.

@isidorn
Copy link
Contributor

isidorn commented May 12, 2020

Thanks for letting us know, adding verified label.

@isidorn isidorn added the verified Verification succeeded label May 12, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Milestone
May 2020
Development

No branches or pull requests
2 participants
@isidorn @gregg-miskelly