Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve focus in status bar #97241

Closed
LeonarddeR opened this issue May 8, 2020 · 2 comments
Closed

Preserve focus in status bar #97241

LeonarddeR opened this issue May 8, 2020 · 2 comments
Assignees
@isidorn
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality on-testplan workbench-status Status bar
Milestone
May 2020

Comments

@LeonarddeR
Copy link

In MS Office, the first entry gets focus by default and if you move focus through items, the focused entry is saved on the status bar so that when you move out/in with f6/shift+f6, the focused item remains the same.

It would be helpful if focus can be retained when the status bar loses focus and gains focus again. This way, you can quickly watch a single entry on the status bar, e.g. horiizontal/vertical position.

As nothing gets focus by default, there should be a way to reset focus as well. May be escape can do this? So if a status bar child is focus, escape can set focus back to the status bar itself.

Originally posted by @LeonarddeR in #95433 (comment)
@microsoft microsoft deleted a comment from vscodebot bot May 8, 2020
@isidorn isidorn self-assigned this May 8, 2020
@isidorn isidorn added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality workbench-status Status bar labels May 8, 2020
@isidorn
Copy link
Contributor

isidorn commented May 8, 2020 •
edited

All this makes sense and I can look into this. Not sure about first item getting focus, that we will probably not due as mentioned here #95433 (comment)

fyi @bpasero since you gave some similar feedback

@isidorn isidorn added this to the May 2020 milestone May 8, 2020
@isidorn isidorn closed this as completed in 09e7f4e May 8, 2020
@isidorn
Copy link
Contributor

isidorn commented May 8, 2020

@LeonarddeR thanks for great feedback. I have pushed the following changes:

  1. focus on a status bar entry gets preserved when you re-focus the status bar
  2. esc while in status bar clear the focus from the entry to the whole status bar

I am open to changing that the iital focus auto-focuses the first element, though did not make that change yet since it might break nice voice over behavior from my previous comment.

@isidorn isidorn mentioned this issue May 11, 2020
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality on-testplan workbench-status Status bar
Projects
None yet
Milestone
May 2020
Development

No branches or pull requests
2 participants
@isidorn @LeonarddeR