Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal attempts to do automatic github authentication even when disabled. #97320

Closed
a-tiller opened this issue May 9, 2020 · 2 comments
Closed

Terminal attempts to do automatic github authentication even when disabled. #97320

a-tiller opened this issue May 9, 2020 · 2 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release git GIT issues verified Verification succeeded
Milestone
April 2020 Recovery

Comments

@a-tiller
Copy link

a-tiller commented May 9, 2020 •
edited

  • VSCode Version: 1.45.0
  • OS Version: Ubuntu 19.10

Steps to Reproduce:

  1. add: { "git.enabled": false, "git.terminalAuthentication": false, "git.githubAuthentication": false, }
    to settings.json
  2. git push from the integrated terminal

Does this issue occur when all extensions are disabled?: Yes

Error text:

Missing or invalid credentials.
Error: connect ENOENT /run/user/1000/snap.code/vscode-git-0ebaf733d8.sock
at PipeConnectWrap.afterConnect [as oncomplete] (net.js:1056:14) {
errno: 'ENOENT',
code: 'ENOENT',
syscall: 'connect',
address: '/run/user/1000/snap.code/vscode-git-0ebaf733d8.sock'
}
@Tyriar
Copy link
Member

Tyriar commented May 9, 2020

Did you restart the terminal after your disabled it?

@a-tiller
Copy link
Author

a-tiller commented May 9, 2020

Yes, I've both killed the terminal and restarted the VM.

Not sure if this is helpful, but before I added the two new settings vscode was trying to handle the authentication even though I had git.enabled: false set (requesting username and password from the command palette). That's what sent me looking for the new settings in the first place.

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release git GIT issues labels May 11, 2020
@joaomoreno joaomoreno added this to the May 2020 Recovery milestone May 11, 2020
joaomoreno added a commit that referenced this issue May 12, 2020
@joaomoreno
disable askpass, terminal and github auth when git is disabled
7d85ec7 
fixes #97320
@joaomoreno joaomoreno mentioned this issue May 12, 2020
Merged
lszomoru pushed a commit that referenced this issue May 12, 2020
@joaomoreno
disable askpass, terminal and github auth when git is disabled (#97604)
d476742 
fixes #97320
@isidorn isidorn added the verified Verification succeeded label May 14, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release git GIT issues verified Verification succeeded
Projects
None yet
Milestone
April 2020 Recovery
Development

No branches or pull requests
4 participants
@joaomoreno @isidorn @Tyriar @a-tiller