Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserting code snippet causes auto scroll to placeholder / top line of snippet #97430

Closed
infalmo opened this issue May 10, 2020 · 6 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete verified Verification succeeded
Milestone

Comments

@infalmo
Copy link

infalmo commented May 10, 2020

Issue Type: Bug

Like what the heading says, inserting a code snippet anywhere in the code file causes an autoscroll. This is a slight inconvenience, as while inserting snippets, viewing code above it is desirable, causing us to rescroll into view. So adding an option to revert to the functionality in the stable release would be preferred

VS Code version: Code - Insiders 1.46.0-insider (d487078, 2020-05-07T16:36:39.681Z)
OS version: Linux x64 5.4.38-1-MANJARO

System Info
Item Value
CPUs Intel(R) Core(TM) i3-3110M CPU @ 2.40GHz (4 x 1744)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: disabled_software
skia_renderer: disabled_off_ok
video_decode: unavailable_off
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled
Load (avg) 0, 0, 0
Memory (System) 5.71GB (1.21GB free)
Process Argv --no-sandbox --unity-launch
Screen Reader no
VM 0%
DESKTOP_SESSION deepin
XDG_CURRENT_DESKTOP Deepin
XDG_SESSION_DESKTOP deepin
XDG_SESSION_TYPE x11
Extensions (4)
Extension Author (truncated) Version
cpptools ms- 0.27.1
Go ms- 0.14.1
material-icon-theme PKi 4.1.0
material-theme zhu 3.5.0

(1 theme extensions excluded)

@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete labels May 12, 2020
@jrieken jrieken added this to the May 2020 milestone May 12, 2020
@jrieken
Copy link
Member

jrieken commented May 12, 2020

Yeah - that's a regression from a recent change to keep the position stable when additional edits are inserted...

@jrieken
Copy link
Member

jrieken commented May 12, 2020

#94173 is the item that caused this regression.

@jrieken
Copy link
Member

jrieken commented May 13, 2020

fixed via c4e781b

@jrieken jrieken closed this as completed May 13, 2020
@jrieken jrieken added the author-verification-requested Issues potentially verifiable by issue author label May 13, 2020
@infalmo
Copy link
Author

infalmo commented May 13, 2020

Yep, it works fine now.
Thanks a lot!

@github-actions
Copy link

This bug has been fixed in to the latest release of VS Code Insiders!

@infixint943, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version e1d8f51 of Insiders (today's or later - you can use Help: About in the command pallette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

@infalmo
Copy link
Author

infalmo commented May 14, 2020

/verified

@jrieken jrieken added the verified Verification succeeded label May 15, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants
@jrieken @infalmo and others