Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot read property 'body' of undefined #97459

Closed
vscodeerrors opened this issue May 11, 2020 · 3 comments
Closed

Cannot read property 'body' of undefined #97459

vscodeerrors opened this issue May 11, 2020 · 3 comments
Assignees
@isidorn
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues error-telemetry VS Code - Issues generated by telemetry
Milestone
May 2020

Comments

@vscodeerrors
Copy link

Issue Id: de429439-c5d5-13b2-ed17-cf9039cae2ae

Versions
- 1.45.0
Stack
TypeError: Cannot read property 'body' of undefined
/vs/workbench/contrib/debug/browser/debugSession.ts#595:15
at processTicksAndRejections (internal/process/task_queues.js:85:5)
@bpasero bpasero added the error-telemetry VS Code - Issues generated by telemetry label May 11, 2020
@isidorn isidorn added this to the May 2020 milestone May 12, 2020
@isidorn isidorn added the debug Debug viewlet, configurations, breakpoints, adapter issues label May 12, 2020
@bpasero
Copy link
Member

bpasero commented May 12, 2020

Just a thought: with strict null checks working properly, I wonder why methods such as

vscode/src/vs/workbench/contrib/debug/browser/rawDebugSession.ts

Line 425 in 5d37bb7

loadedSources(args: DebugProtocol.LoadedSourcesArguments): Promise<DebugProtocol.LoadedSourcesResponse> {
are not typed in a way that you account for undefined or null values. Seems like this should be handled on the level of the language?

@bpasero
Copy link
Member

bpasero commented May 12, 2020

E.g. in a way how 4fee76e was fixed

@isidorn
Copy link
Contributor

isidorn commented May 12, 2020

Thought about that fix actually. The problem with that is that I would have to change the signature of all the rawDebugSession methods and this only happens in a weird corner case when it is triggered on a debug session shutdown.
So yes I agree with you we should fix it like that. I would just wait for potenitally more corner case, as for just one I would not change the whole world.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
debug Debug viewlet, configurations, breakpoints, adapter issues error-telemetry VS Code - Issues generated by telemetry
Projects
None yet
Milestone
May 2020
Development

No branches or pull requests
3 participants
@bpasero @isidorn @vscodeerrors