Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There are two KeytarCredentialsService implementations #97501

Closed
jrieken opened this issue May 11, 2020 · 1 comment
Closed

There are two KeytarCredentialsService implementations #97501

jrieken opened this issue May 11, 2020 · 1 comment
Assignees
@bpasero @chrmarti
Labels
debt Code quality issues
Milestone
May 2020

Comments

@jrieken
Copy link
Member

jrieken commented May 11, 2020

We have

  1. src/vs/workbench/services/credentials/node/credentialsService.ts and
  2. src/vs/platform/credentials/node/credentialsService.ts

Both look very, very similar

image
@sandy081 sandy081 assigned bpasero and chrmarti and unassigned sandy081 May 12, 2020
@sandy081
Copy link
Member

I don't remember who created these two, but history shows @bpasero and @chrmarti . Hence assigning them.

Seems first one src/vs/workbench/services/credentials/node/credentialsService.ts is not used anywhere.

@bpasero bpasero added the debt Code quality issues label May 12, 2020
@bpasero bpasero added this to the May 2020 milestone May 12, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

@chrmarti chrmarti

Labels
debt Code quality issues
Projects
None yet
Milestone
May 2020
Development

No branches or pull requests
4 participants
@bpasero @jrieken @chrmarti @sandy081