Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo any type #97636

Closed
joaomoreno opened this issue May 12, 2020 · 3 comments
Closed

Undo any type #97636

joaomoreno opened this issue May 12, 2020 · 3 comments
Assignees
@mjbvz

Comments

@joaomoreno
Copy link
Member

This is causing a compilation error both in yarn watch and in VS Code:

cd93eaa
@mjbvz
Copy link
Contributor

mjbvz commented May 12, 2020 •
edited

Hey I don't think this change is required. Just delete the node_modules under search-results and run yarn again

@mjbvz
Copy link
Contributor

mjbvz commented May 12, 2020

Builds were also green with my original change in: https://dev.azure.com/vscode/VSCode/_build/results?buildId=43448&view=results

Let me know if you see any failures in the build tasks

@mjbvz mjbvz closed this as completed in 2344d7c May 12, 2020
@joaomoreno
Copy link
Member Author

Was missing to remove node_modules, I expected yarn to simply do the right thing. 🤔

@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joaomoreno @mjbvz