New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onDidOpenNotebookDocument fires notebook has no cells #97694

Closed

jrieken opened this issue May 13, 2020 · 1 comment

Assignees

Labels

bug notebook verified

Milestone

Member

jrieken commented May 13, 2020

the GH issues notebooks has this https://github.com/microsoft/vscode-github-issue-notebooks/blob/de9a43406d854c87e0b150b5b58e276f7d2a9bd2/src/notebookProvider.ts#L49
🐛 when the event fires notebooks have no cells ([]) which means the project isn't setup correctly

The real world impact be seen like this

have a cell that defines a variable
have a cell that uses the variable
collapse the former
reload -> compile errors...
expand -> all good

The text was updated successfully, but these errors were encountered:

jrieken assigned rebornix

jrieken added the notebook label

rebornix added the bug label

rebornix added this to the May 2020 milestone

rebornix closed this as completed in

9a38476

Member

rebornix commented May 18, 2020 •

edited

Good catch, it was broken after introducing the backup. Will add tests once we have smoke test infra setup.

jrieken added the verified label

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.