Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make repl themable #97695

Closed
aeschli opened this issue May 13, 2020 · 5 comments · Fixed by #97762
Closed

Make repl themable #97695

aeschli opened this issue May 13, 2020 · 5 comments · Fixed by #97762
Assignees
@isidorn
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality on-release-notes Issue/pull request mentioned in release notes themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
May 2020

Comments

@aeschli
Copy link
Contributor

aeschli commented May 13, 2020 •
edited

I stumbled over repl.css and saw that there are still many colors hard-coded.

Also while at the .css file, it's good practice to qualify all rules with .monaco-workbench (or .monaco-editor) now that the workbench can be embedded in the web.
isidorn added a commit that referenced this issue May 13, 2020
@isidorn
repl: introduce .monaco-workbench selector and remove unused css
ecf39a0 
#97695
@isidorn
Copy link
Contributor

isidorn commented May 13, 2020 •
edited

Thanks @aeschli for great feedback.
There was some unused CSS, like the .annotation in the repl, so I removed that. I have also now qualifed all with .monaco-workbench.

There is still one hard coded color for .warn in repl, but I believe @robertrossmann tackled this with his great PR. Though I might be mistaken?

@isidorn isidorn added debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues labels May 13, 2020
@robertrossmann
Copy link
Contributor

@isidorn I did, indeed, add colour contribution points to the REPL as part of #94838 but eventually you asked me to defer those until later, I do not remember the reason precisely... 🤔 So the REPL is still not theme-able, unfortunately.

@isidorn
Copy link
Contributor

isidorn commented May 13, 2020

@robertrossmann thanks for refreshing my memory.
In case you would like to contribute that part of your PR we are open to accept it now :D
From the .css I only see a need for warn color, not sure if there is more.

@isidorn isidorn added this to the On Deck milestone May 13, 2020
@bpasero bpasero added the themes Color theme issues label May 13, 2020
@robertrossmann
Copy link
Contributor

@isidorn I am working on this now. ✅

I am taking it a step further, though, and adding theming to most of the REPL elements (errors, warnings, infos, source filenames etc.). Basically I want the whole REPL view to be fully customisable. 💪 🚀

@robertrossmann robertrossmann mentioned this issue May 13, 2020
Merged
@isidorn isidorn modified the milestones: On Deck, May 2020 May 18, 2020
@isidorn isidorn added feature-request Request for new features or functionality verification-needed Verification of issue is requested and removed debt Code quality issues labels May 18, 2020
@isidorn
Copy link
Contributor

isidorn commented May 18, 2020

To verify, make sure you can customise the following colors in the debug console. You can use the setting workbench.colorCusomisations:

debugConsole.infoForeground
debugConsole.warningForeground
debugConsole.errorForeground
debugConsole.sourceForeground
debugConsoleInputIcon.foreground

@connor4312 connor4312 added the verified Verification succeeded label Jun 2, 2020
@isidorn isidorn added the on-release-notes Issue/pull request mentioned in release notes label Jun 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality on-release-notes Issue/pull request mentioned in release notes themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
May 2020
Development

Successfully merging a pull request may close this issue.

feat: implement colour contributions for debug REPL
5 participants
@bpasero @isidorn @connor4312 @robertrossmann @aeschli