Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate ts-ignore actions returned if there are multiple errors on one line #97867

Closed
mjbvz opened this issue May 15, 2020 · 0 comments
Closed

Duplicate ts-ignore actions returned if there are multiple errors on one line #97867

mjbvz opened this issue May 15, 2020 · 0 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug editor-code-actions Editor inplace actions (Ctrl + .) javascript JavaScript support issues verified Verification succeeded
Milestone
May 2020

Comments

@mjbvz
Copy link
Contributor

mjbvz commented May 15, 2020

Issue Type: Bug

Repro

  1. In a JS file:
//@ts-check
const a = require('./bla')
  1. Select the entire line and trigger quick fixes

Bug

The ignore actions are returned twice

Screen Shot 2020-05-14 at 9 58 19 PM

VS Code version: Code - Insiders 1.46.0-insider (e1d8f51, 2020-05-13T20:32:52.338Z)
OS version: Darwin x64 19.4.0

System Info
Item Value
CPUs Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled
Load (avg) 2, 2, 2
Memory (System) 32.00GB (0.13GB free)
Process Argv -psn_0_59869461
Screen Reader no
VM 11%
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues editor-code-actions Editor inplace actions (Ctrl + .) labels May 15, 2020
@mjbvz mjbvz self-assigned this May 15, 2020
@mjbvz mjbvz added this to the May 2020 milestone May 20, 2020
@mjbvz mjbvz closed this as completed in 85a336c May 20, 2020
@lramos15 lramos15 added the verified Verification succeeded label Jun 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug editor-code-actions Editor inplace actions (Ctrl + .) javascript JavaScript support issues verified Verification succeeded
Projects
None yet
Milestone
May 2020
Development

No branches or pull requests
2 participants
@lramos15 @mjbvz