Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error from "saveNotebook" in notebook provider is swallowed #97998

Closed
roblourens opened this issue May 16, 2020 · 0 comments
Closed

Error from "saveNotebook" in notebook provider is swallowed #97998

roblourens opened this issue May 16, 2020 · 0 comments
Assignees
@roblourens @rebornix
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded

Comments

@roblourens
Copy link
Member

  • Implement saveNotebook in a NotebookContentProvider to throw
  • Save a notebook
  • The error doesn't show up anywhere, I think it should produce an error notification
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug notebook labels May 16, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2020
@rzhao271 rzhao271 added the verified Verification succeeded label Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@roblourens @rebornix @rzhao271 and others