Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor group isn't focused when notebook gets focus #98036

Closed
roblourens opened this issue May 17, 2020 · 0 comments
Closed

Editor group isn't focused when notebook gets focus #98036

roblourens opened this issue May 17, 2020 · 0 comments
Assignees
@roblourens @rebornix
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority notebook verified Verification succeeded
Milestone
May 2020

Comments

@roblourens
Copy link
Member

  • Open two editor groups, one with a notebook and one with a text editor or empty
  • Click into the second, its editor group is focused
  • Click into the notebook, the group is not focused (the title bar is still gray)

The Composite is tracking focus on the editor container and now the notebook is outside of that. We need to signal focus manually or tell it to track a different element

vscode/src/vs/workbench/browser/composite.ts

Line 65 in 957534c

const focusTracker = this._register(trackFocus(container));

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug notebook labels May 17, 2020
@roblourens roblourens added this to the May 2020 milestone May 17, 2020
@rebornix rebornix added the important Issue identified as high-priority label May 18, 2020
@Tyriar Tyriar added the verified Verification succeeded label Jun 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority notebook verified Verification succeeded
Projects
None yet
Milestone
May 2020
Development

No branches or pull requests
3 participants
@roblourens @rebornix @Tyriar