Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Insiders] Experimental Use Title Event Issue with Powershell 7 #98262

Closed
JustinGrote opened this issue May 20, 2020 · 4 comments
Closed

[Insiders] Experimental Use Title Event Issue with Powershell 7 #98262

JustinGrote opened this issue May 20, 2020 · 4 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues verified Verification succeeded windows VS Code on Windows issues
Milestone
June 2020

Comments

@JustinGrote
Copy link
Contributor

Issue Type: Bug

Trying to use the new setting with Powershell 7. It does "work" except it constantly reverts the title to "pwsh" or "git" rather than what the UI has set for the terminal title after the script has completed. The loop is used in the example just to show that it reverts after script completion and not after each title "change".
Capture

Looping @TylerLeonhardt in case he has any insight.

VS Code version: Code - Insiders 1.46.0-insider (da3bf75, 2020-05-19T10:07:59.927Z)
OS version: Windows_NT x64 10.0.19041

System Info
Item Value
CPUs Intel(R) Core(TM) i5-1035G7 CPU @ 1.20GHz (8 x 1498)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: enabled
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 7.60GB (1.27GB free)
Process Argv
Screen Reader no
VM 0%
Extensions (34)
Extension Author (truncated) Version
azureautomation Awe 1.0.2
bracket-pair-colorizer-2 Coe 0.1.3
gitlens eam 10.2.1
vs-code-xml-format fab 0.1.5
vscode-pull-request-github Git 0.16.1
gc-excelviewer Gra 2.1.34
todo-tree Gru 0.0.175
vscode-drawio hed 0.4.0
vscode-peacock joh 3.7.2
better-powershell-syntax-highlighting jus 0.0.2
git-graph mhu 1.22.0
azure-pipelines ms- 1.170.0
vscode-azurefunctions ms- 0.22.1
vscode-azurestorage ms- 0.9.0
vscode-docker ms- 1.2.0
csharp ms- 1.21.18
remote-containers ms- 0.117.1
remote-ssh-edit-nightly ms- 2020.5.19620
remote-ssh-nightly ms- 2020.5.19620
remote-wsl ms- 0.44.2
azure-account ms- 0.8.11
powershell-preview ms- 2020.5.0
vsonline ms- 1.0.2220
team ms- 1.161.0
indent-rainbow ode 7.4.0
vscode-yaml red 0.8.0
vscode-sort-json ric 1.18.0
vscode-zipexplorer sle 0.3.1
vscode-icons vsc 10.1.1
codetour vsl 0.0.26
gistfs vsl 0.0.67
gitdoc vsl 0.0.6
better-align wwm 1.1.6
markdown-all-in-one yzh 2.8.0
@Tyriar
Copy link
Member

Tyriar commented Jun 8, 2020

I suspect this is working as designed as pwsh would set it again when you return to the prompt? @TylerLeonhardt?

To test use "terminal.integrated.experimentalUseTitleEvent": true

@Tyriar Tyriar added the info-needed Issue requires more information from poster label Jun 8, 2020
@TylerLeonhardt
Copy link
Member

No I don't think we do that:

Screen-Cast-2020-06-08-at-12 52 58-PM

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug windows VS Code on Windows issues terminal Integrated terminal issues and removed info-needed Issue requires more information from poster labels Jun 9, 2020
@Tyriar Tyriar added this to the June 2020 milestone Jun 9, 2020
@Tyriar Tyriar closed this as completed in 676f90d Jun 9, 2020
@JustinGrote
Copy link
Contributor Author

@Tyriar @TylerLeonhardt Confirmed fixed and working in latest insiders. Thanks!

@Tyriar Tyriar added the verified Verification succeeded label Jun 12, 2020
@Tyriar
Copy link
Member

Tyriar commented Jun 12, 2020

Thanks for verifying 🙂

@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Milestone
June 2020
Development

No branches or pull requests
4 participants
@Tyriar @TylerLeonhardt @JustinGrote and others