Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit in settings.json adds entry in the wrong place for multi root workspace settings #98774

Closed
ramya-rao-a opened this issue May 29, 2020 · 1 comment
Closed

Edit in settings.json adds entry in the wrong place for multi root workspace settings #98774

ramya-rao-a opened this issue May 29, 2020 · 1 comment
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug config VS Code configuration, set up issues insiders-released Patch has been released in VS Code Insiders settings-editor VS Code settings editor issues verified Verification succeeded
Milestone
June 2020

Comments

@ramya-rao-a
Copy link
Contributor

  • VSCode Version: 1.46.0-insider
  • OS Version: MacOS Mojave

Steps to Reproduce:

  1. Create a multi root workspace
  2. Open settings, select Workspace, search for ligatures
  3. You will find the setting Editor: Font Ligatures, select Edit in settings.json

This should add "editor.fontLigatures": null under settings in the json file for Workspace settings. Instead, the same is added as a sibling to the settings key in the json file

This happens to any settings that has the Edit in settings.json option

For screenshots, you can refer to microsoft/vscode-go#3214 which uses a different setting

Does this issue occur when all extensions are disabled?: Yes
@vscodebot
Copy link

vscodebot bot commented May 29, 2020

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@ramya-rao-a ramya-rao-a changed the title Edit in settings.json adds entry in the wrong place for Multi root workspace settings Edit in settings.json adds entry in the wrong place for multi root workspace settings May 29, 2020
@ramya-rao-a ramya-rao-a mentioned this issue May 29, 2020
Closed
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug config VS Code configuration, set up issues settings-editor VS Code settings editor issues labels Jun 2, 2020
@sandy081 sandy081 modified the milestones: May 2020, Backlog Jun 2, 2020
@sandy081 sandy081 modified the milestones: Backlog, June 2020 Jun 11, 2020
@roblourens roblourens added the verified Verification succeeded label Jul 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug config VS Code configuration, set up issues insiders-released Patch has been released in VS Code Insiders settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Milestone
June 2020
Development

No branches or pull requests
4 participants
@roblourens @sandy081 @ramya-rao-a and others