Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting debug.console.closeOnEnd does not work after debug console was moved #99050

Closed
Fell opened this issue Jun 2, 2020 · 2 comments
Closed

Setting debug.console.closeOnEnd does not work after debug console was moved #99050

Fell opened this issue Jun 2, 2020 · 2 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
May 2020

Comments

@Fell
Copy link

Fell commented Jun 2, 2020

Issue Type: Bug

  1. Set up an environment that makes use of debug.console.closeOnEnd
  2. Click and drag the debug console somewhere else, for example in the side bar or the panel.
    → debug.console.closeOnEnd does not work anymore
  3. Move the debug console back where it was
    → debug.console.closeOnEnd still does not work

I found out, that the debug console is in a "dirty" state as long as the right click option "Reset View Location" is available. When I click "Reset View Location", said option disappears and the functionality of debug.console.closeOnEnd is restored.
However, this is very confusing as there is no visual clue as to why the debug console does not close.
At least add this to the description of the setting.

VS Code version: Code 1.45.1 (5763d90, 2020-05-14T08:27:35.169Z)
OS version: Windows_NT x64 10.0.18362

System Info
Item Value
CPUs Intel(R) Core(TM) i5-4690K CPU @ 3.50GHz (4 x 3500)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.95GB (7.01GB free)
Process Argv
Screen Reader no
VM 0%
Extensions (8)
Extension Author (truncated) Version
increment-selection alb 0.2.0
vscode-perforce-simple cal 1.0.1
gltf-vscode ces 2.2.10
vscode-icon-theme jtl 1.6.6
cpptools ms- 0.28.2
shader sle 1.1.4
rewrap stk 1.11.1
sort-lines Tyr 1.9.0

(1 theme extensions excluded)
@isidorn
Copy link
Contributor

isidorn commented Jun 2, 2020 •
edited

I acklowedge this bug and we can look into it. We make wrong assumptions that debug console is in the panel.
Code pointer https://github.com/microsoft/vscode/blob/05e851b52978f08a7d7780feeff26a121e31c0d1/src/vs/workbench/contrib/debug/browser/debugService.ts#L600

@isidorn isidorn added this to the May 2020 milestone Jun 2, 2020
@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Jun 2, 2020
@isidorn isidorn closed this as completed in 9f640d4 Jun 3, 2020
@connor4312 connor4312 added the verified Verification succeeded label Jun 4, 2020
@Fell Fell mentioned this issue Jun 15, 2020
Closed
@Fell
Copy link
Author

Fell commented Jun 15, 2020

It works as expected now, however, I miss the old functionality that closed the whole panel after debugging. I created a feature request: #100182

@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
May 2020
Development

No branches or pull requests
4 participants
@Fell @isidorn @connor4312 and others