Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"This extension is enabled globally" too vague description #99105

Closed
sandy081 opened this issue Jun 2, 2020 · 2 comments
Closed

"This extension is enabled globally" too vague description #99105

sandy081 opened this issue Jun 2, 2020 · 2 comments
Assignees
@sandy081
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue settings-sync
Milestone
May 2020

Comments

@sandy081
Copy link
Member

sandy081 commented Jun 2, 2020

Have an extension which should not be synced.
notice how we use a nice icon of not syncing, however the hover text is too vague. It should be more specific. For example "This extension will not get synced"
Enabled globally is not really cleart to me as a user

Screenshot 2020-06-02 at 15 42 30
@sandy081 sandy081 added polish Cleanup and polish issue settings-sync labels Jun 2, 2020
@sandy081 sandy081 added this to the May 2020 milestone Jun 2, 2020
@sandy081 sandy081 self-assigned this Jun 2, 2020
@sandy081
Copy link
Member Author

sandy081 commented Jun 2, 2020

This tool tip is a general tool tip for the extension. But agreed to show specific message when hovered on ignored sync icon.

@sandy081
Copy link
Member Author

sandy081 commented Jun 3, 2020

It has tooltip but was not shown because of setting pointer-events to none. This was set for this - #93989.

Reverted that change because it is more important to have hover than that.

@sandy081 sandy081 mentioned this issue Jun 3, 2020
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2020
sandy081 added a commit that referenced this issue Nov 3, 2020
@sandy081
Fix #99105
b9833bb
@sandy081 sandy081 modified the milestones: May 2020, November 2020 Nov 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue settings-sync
Projects
None yet
Milestone
May 2020
Development

No branches or pull requests
2 participants
@sandy081 and others