Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode:displayChanged is sent only on mac #99313

Closed
alexdima opened this issue Jun 3, 2020 · 0 comments
Closed

vscode:displayChanged is sent only on mac #99313

alexdima opened this issue Jun 3, 2020 · 0 comments
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
November 2020

Comments

@alexdima
Copy link
Member

alexdima commented Jun 3, 2020 •
edited

Following the discussion in 36996ca

Repro steps on Windows:

  • use a monospace font, make sure ligatures are not used, etc. (i.e. default editor related settings)
  • change the scale setting of the display
  • the editor decorations / selection should render correctly (on top of the correct text)

(the problem was that the font measurements done with a certain display scale were used across all display scales).
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Jun 3, 2020
@alexdima alexdima self-assigned this Jun 3, 2020
@alexdima alexdima added this to the May 2020 milestone Jun 3, 2020
@alexdima alexdima changed the title vscode:displayChanged is sent only on mac vscode:displayChanged is sent only on mac Jun 3, 2020
alexdima referenced this issue Jun 3, 2020
@alexdima
Clear font info when displays are added, removed or changed
36996ca
@alexdima alexdima modified the milestones: May 2020, June 2020 Jun 4, 2020
@alexdima alexdima modified the milestones: June 2020, July 2020 Jul 2, 2020
Tek-God referenced this issue Jul 4, 2020
@bpasero
🆙 playwright@1.0.1 (#97789)
5763d90
@alexdima alexdima modified the milestones: July 2020, On Deck Aug 6, 2020
@alexdima alexdima modified the milestones: On Deck, November 2020 Nov 20, 2020
@alexdima alexdima mentioned this issue Nov 20, 2020
Closed
chenjigeng pushed a commit to chenjigeng/vscode that referenced this issue Nov 22, 2020
@alexdima
Fixes microsoft#99313
3178922
@mjbvz mjbvz added verified Verification succeeded and removed verified Verification succeeded labels Dec 4, 2020
@rzhao271 rzhao271 added the verified Verification succeeded label Dec 8, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
November 2020
Development

No branches or pull requests
4 participants
@alexdima @rzhao271 @mjbvz and others