I'm pretty sure that if you open two notebooks, the second is overwriting the context keys of the first. How this works for code editors - they need to unwrap an ICodeEditor here:

@bpasero I'm confused about that code, it looks like I would need to extend it for every editor type in order to get the editor title control to render actions using the editor's contextKeyService?

@roblourens we can use

const activeControl = activeEditorPane.getControl();
if (isCompositeEditor(activeControl) && isCodeEditor(activeControl.activeCodeEditor)) {
	return activeControl.activeCodeEditor;
}

maybe we should copy logic from

to

@jrieken is it safe to do that?

Well, I don't want the context key service from the code editor inside the notebook editor, I want it from the notebook editor itself.

right, I misread it. I think then we can extend

by adding invokeWithinContext

@roblourens I cannot recall, I think Jo wrote that code to ensure the title menu gets the most appropriate context key service before rendering.

I want it from the notebook editor itself.

Each editor group gets a dedicated context key service - a simple way to enumerate them is to paste this into the console document.querySelectorAll('[data-keybinding-context]').

I am not quite sure what the actual issue is but I can image that there a problem because context key hierarchies work along the dom structure and given that notebook editors might not always follow that structure, right?

The real issue is what to do when we move a notebook from one group to another, and that partly determines whether the editor should get its own group or not. Currently we keep the notebook widget alive when the Editor is recreated in the new group, to avoid disposing the webview. So we can

• Reinstantiate the notebook widget, and only keep the webview alive. Peng says this is hard because the notebook list and the webview are tightly coupled.
• Give the notebook widget its own contextKeyService and reparent this into the new editor group context key service. Currently this isn't possible but doesn't look too difficult. But is definitely weird

After fixing https://github.com/microsoft/vscode/issues, this is an issue again

• Drag notebook from group A to group B
• Close group A
• Now looking up context keys fails